FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

test: refactor test-crypto-padding-aes256 by radelmann · Pull Request #10622 · nodejs/node · GitHub

/ node Public

test: refactor test-crypto-padding-aes256 - #10622

Closed
radelmann wants to merge 1 commit into
nodejs:masterfrom
radelmann:test-crypto-padding-eas256.js
Closed

test: refactor test-crypto-padding-aes256#10622
radelmann wants to merge 1 commit into
nodejs:masterfrom
radelmann:test-crypto-padding-eas256.js

Conversation

Copy link
Copy Markdown
Contributor
  • replace var with const/let
  • replace assert.equal() with assert.strictEqual()
Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • commit message follows commit guidelines
Affected core subsystem(s)

test

nodejs-github-bot added test Issues and PRs related to the tests. lts-watch-v6.x labels Jan 5, 2017
mscdex added the crypto Issues and PRs related to the crypto subsystem. label Jan 5, 2017

Trott commented Jan 5, 2017

Copy link
Copy Markdown
Member

Nit: typo in commit message and PR title: eas256 -> aes256

radelmann changed the title test: refactor test-crypto-padding-eas256 test: refactor test-crypto-padding-aes256 Jan 5, 2017
- replace var with const/let
- replace assert.equal() with assert.strictEqual()

Copy link
Copy Markdown
Contributor Author

bump

jasnell commented Jan 10, 2017

Copy link
Copy Markdown
Member

jasnell pushed a commit that referenced this pull request Jan 10, 2017
* replace var with const/let
* replace assert.equal() with assert.strictEqual()

PR-URL: #10622
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>

jasnell commented Jan 10, 2017

Copy link
Copy Markdown
Member

Landed in 596d86f

jasnell closed this Jan 10, 2017
italoacasas pushed a commit to italoacasas/node that referenced this pull request Jan 18, 2017
* replace var with const/let
* replace assert.equal() with assert.strictEqual()

PR-URL: nodejs#10622
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
italoacasas pushed a commit to italoacasas/node that referenced this pull request Jan 23, 2017
* replace var with const/let
* replace assert.equal() with assert.strictEqual()

PR-URL: nodejs#10622
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
italoacasas pushed a commit to italoacasas/node that referenced this pull request Jan 25, 2017
* replace var with const/let
* replace assert.equal() with assert.strictEqual()

PR-URL: nodejs#10622
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
italoacasas pushed a commit to italoacasas/node that referenced this pull request Jan 27, 2017
* replace var with const/let
* replace assert.equal() with assert.strictEqual()

PR-URL: nodejs#10622
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
italoacasas mentioned this pull request Jan 29, 2017
MylesBorins pushed a commit that referenced this pull request Mar 8, 2017
* replace var with const/let
* replace assert.equal() with assert.strictEqual()

PR-URL: #10622
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
MylesBorins pushed a commit that referenced this pull request Mar 9, 2017
* replace var with const/let
* replace assert.equal() with assert.strictEqual()

PR-URL: #10622
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
MylesBorins mentioned this pull request Mar 9, 2017
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

crypto Issues and PRs related to the crypto subsystem. test Issues and PRs related to the tests.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants


Back | FazBrowse Home | New Git URL