test: improve code in test-https-strict - #10648
Closed
edsadr wants to merge 1 commit into
Closed
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
cjihrig
approved these changes
Jan 6, 2017
Trott
reviewed
Jan 6, 2017
Comment thread
test/parallel/test-https-strict.js
Outdated
Copy link
Copy Markdown
Member
There was a problem hiding this comment.
While we're refactoring: It looks like port on line 78 is unused. If that's the case, can you remove it?
Sorry, something went wrong.
* use let and const instead of var * use assert.strictEqual instead of assert.equal * remove unused var
Copy link
Copy Markdown
Contributor
Author
|
@Trott , removed the unused var |
Sorry, something went wrong.
jasnell
approved these changes
Jan 6, 2017
lpinca
approved these changes
Jan 6, 2017
mhdawson
approved these changes
Jan 6, 2017
mhdawson
left a comment
Copy link
Copy Markdown
Member
There was a problem hiding this comment.
LGTM
Sorry, something went wrong.
Copy link
Copy Markdown
Member
Sorry, something went wrong.
jasnell
pushed a commit
that referenced
this pull request
Jan 9, 2017
* use let and const instead of var * use assert.strictEqual instead of assert.equal * remove unused var PR-URL: #10648 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
italoacasas
pushed a commit
to italoacasas/node
that referenced
this pull request
Jan 18, 2017
* use let and const instead of var * use assert.strictEqual instead of assert.equal * remove unused var PR-URL: nodejs#10648 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
italoacasas
pushed a commit
to italoacasas/node
that referenced
this pull request
Jan 23, 2017
* use let and const instead of var * use assert.strictEqual instead of assert.equal * remove unused var PR-URL: nodejs#10648 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
italoacasas
pushed a commit
to italoacasas/node
that referenced
this pull request
Jan 25, 2017
* use let and const instead of var * use assert.strictEqual instead of assert.equal * remove unused var PR-URL: nodejs#10648 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
italoacasas
pushed a commit
to italoacasas/node
that referenced
this pull request
Jan 27, 2017
* use let and const instead of var * use assert.strictEqual instead of assert.equal * remove unused var PR-URL: nodejs#10648 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist
Affected core subsystem(s)
test