FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

docs: "s/git apply/git am -3" in V8 guide by MylesBorins · Pull Request #10665 · nodejs/node · GitHub

/ node Public

docs: "s/git apply/git am -3" in V8 guide - #10665

Closed
MylesBorins wants to merge 1 commit into
nodejs:masterfrom
MylesBorins:update-V8-guide
ConversationCommits (1)ChecksFiles changed
Closed

docs: "s/git apply/git am -3" in V8 guide#10665
MylesBorins wants to merge 1 commit into
nodejs:masterfrom
MylesBorins:update-V8-guide

Conversation

MylesBorins commented Jan 6, 2017

Copy link
Copy Markdown
Contributor

git apply does not preserve the original commit message. These updated
instructions offer a simpler flow for backporting.

nodejs-github-bot added the doc Issues and PRs related to the documentations. label Jan 6, 2017
targos reviewed Jan 6, 2017
View reviewed changes
Comment thread doc/guides/maintaining-V8.md Outdated

targos Jan 6, 2017

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

It seems something is missing after "git commit --amend"

MylesBorins Jan 6, 2017

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

I've added `--author="First Last your@email.address"

That should just work afaik

targos Jan 6, 2017

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

It's not what I meant, but I'd suggest --reset-author.
My comment was about the placement of the command in the text. Maybe add a period after it?

MylesBorins Jan 6, 2017

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

fixed PTAL

mscdex added the v8 engine Issues and PRs related to the V8 dependency. label Jan 6, 2017
MylesBorins force-pushed the update-V8-guide branch 2 times, most recently from 4847afd to 544d7ff Compare January 6, 2017 22:34

gibfahn commented Jan 6, 2017

Copy link
Copy Markdown
Member

Should it be doc: rather than docs: in the commit message?

doc: "s/git apply/git am -3" in V8 guide
f5c22b2 
git apply does not preserve the original commit message. These updated
instructions offer a simpler flow for backporting.
jasnell pushed a commit that referenced this pull request Jan 10, 2017
doc: "s/git apply/git am -3" in V8 guide
db14687 
git apply does not preserve the original commit message. These updated
instructions offer a simpler flow for backporting.

PR-URL: #10665
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
Reviewed-By: Michal Zasso <targos@protonmail.com>

jasnell commented Jan 10, 2017 •
edited by gibfahn
Loading

Copy link
Copy Markdown
Member

Landed in db14687

jasnell closed this Jan 10, 2017
italoacasas pushed a commit to italoacasas/node that referenced this pull request Jan 18, 2017
doc: "s/git apply/git am -3" in V8 guide
008459b 
git apply does not preserve the original commit message. These updated
instructions offer a simpler flow for backporting.

PR-URL: nodejs#10665
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
Reviewed-By: Michal Zasso <targos@protonmail.com>
italoacasas pushed a commit to italoacasas/node that referenced this pull request Jan 23, 2017
doc: "s/git apply/git am -3" in V8 guide
19806da 
git apply does not preserve the original commit message. These updated
instructions offer a simpler flow for backporting.

PR-URL: nodejs#10665
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
Reviewed-By: Michal Zasso <targos@protonmail.com>
italoacasas pushed a commit to italoacasas/node that referenced this pull request Jan 24, 2017
doc: "s/git apply/git am -3" in V8 guide
bd501fb 
git apply does not preserve the original commit message. These updated
instructions offer a simpler flow for backporting.

PR-URL: nodejs#10665
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
Reviewed-By: Michal Zasso <targos@protonmail.com>
italoacasas mentioned this pull request Jan 25, 2017
Closed
italoacasas pushed a commit to italoacasas/node that referenced this pull request Jan 27, 2017
doc: "s/git apply/git am -3" in V8 guide
bf95b07 
git apply does not preserve the original commit message. These updated
instructions offer a simpler flow for backporting.

PR-URL: nodejs#10665
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
Reviewed-By: Michal Zasso <targos@protonmail.com>
italoacasas mentioned this pull request Jan 29, 2017
Merged
MylesBorins added a commit that referenced this pull request Mar 7, 2017
doc: "s/git apply/git am -3" in V8 guide
fc4dccb 
git apply does not preserve the original commit message. These updated
instructions offer a simpler flow for backporting.

PR-URL: #10665
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
Reviewed-By: Michal Zasso <targos@protonmail.com>
MylesBorins added a commit that referenced this pull request Mar 7, 2017
doc: "s/git apply/git am -3" in V8 guide
a2cf0cb 
git apply does not preserve the original commit message. These updated
instructions offer a simpler flow for backporting.

PR-URL: #10665
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
Reviewed-By: Michal Zasso <targos@protonmail.com>
MylesBorins added a commit that referenced this pull request Mar 9, 2017
doc: "s/git apply/git am -3" in V8 guide
7e5a59e 
git apply does not preserve the original commit message. These updated
instructions offer a simpler flow for backporting.

PR-URL: #10665
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
Reviewed-By: Michal Zasso <targos@protonmail.com>
MylesBorins mentioned this pull request Mar 9, 2017
Merged
MylesBorins added a commit that referenced this pull request Mar 9, 2017
doc: "s/git apply/git am -3" in V8 guide
56b779d 
git apply does not preserve the original commit message. These updated
instructions offer a simpler flow for backporting.

PR-URL: #10665
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
Reviewed-By: Michal Zasso <targos@protonmail.com>
MylesBorins mentioned this pull request Mar 9, 2017
Merged
MylesBorins deleted the update-V8-guide branch November 14, 2017 17:45
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

jasnell jasnell approved these changes
+2 more reviewers
targos targos approved these changes
gibfahn gibfahn approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

doc Issues and PRs related to the documentations. v8 engine Issues and PRs related to the V8 dependency.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

Back | FazBrowse Home | New Git URL