test: add test-cluster-worker-deprecated - #10675
Conversation
Sorry, something went wrong.
Add test to cover setter for deprecated cluster Worker property. Previously, the setter was not being exercised in tests.
Sorry, something went wrong.
| this.exitedAfterDisconnect = undefined; | ||
|
|
||
| Object.defineProperty(this, 'suicide', { | ||
| get: internalUtil.deprecate(() => { |
There was a problem hiding this comment.
I would describe this as cluster: better suicide deprecation message (or something of the like), since its a change to improve the deprecation message, along with a unit test for that change.
Sorry, something went wrong.
There was a problem hiding this comment.
@sam-github The deprecation message is not being changed here.
The new test exercises the getter and setter. They were not being exercised. The code change to cluster.js refactor the getter/setter for clarity (good-bye, string concatenation), but do not change the behavior.
Sorry, something went wrong.
There was a problem hiding this comment.
OK, I missed that, the diff is hard to read. Shouldn't a change to lib/cluster.js have cluster: in its commit message? Even if its just a stylistic change?
Sorry, something went wrong.
Add test to cover setter for deprecated cluster Worker property. Previously, the setter was not being exercised in tests. PR-URL: nodejs#10675 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Sam Roberts <vieuxtech@gmail.com>
Add test to cover setter for deprecated cluster Worker property. Previously, the setter was not being exercised in tests. PR-URL: nodejs#10675 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Sam Roberts <vieuxtech@gmail.com>
Add test to cover setter for deprecated cluster Worker property. Previously, the setter was not being exercised in tests. PR-URL: nodejs#10675 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Sam Roberts <vieuxtech@gmail.com>
Add test to cover setter for deprecated cluster Worker property. Previously, the setter was not being exercised in tests. PR-URL: nodejs#10675 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Sam Roberts <vieuxtech@gmail.com>
Add test to cover setter for deprecated cluster Worker property. Previously, the setter was not being exercised in tests. PR-URL: nodejs#10675 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Sam Roberts <vieuxtech@gmail.com>
|
This does not land cleanly in LTS. Added dont-land label. Please feel free to manually backport |
Sorry, something went wrong.
Add test to cover setter for deprecated cluster Worker property.
Previously, the setter was not being exercised in tests.
Checklist
Affected core subsystem(s)
test cluster