FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

test: refactor test-watch-file.js by sivaprs · Pull Request #10679 · nodejs/node · GitHub

/ node Public

test: refactor test-watch-file.js - #10679

Closed
sivaprs wants to merge 2 commits into
nodejs:masterfrom
sivaprs:test-2017_2
ConversationCommits (2)ChecksFiles changed
Closed

test: refactor test-watch-file.js#10679
sivaprs wants to merge 2 commits into
nodejs:masterfrom
sivaprs:test-2017_2

Conversation

sivaprs commented Jan 7, 2017

Copy link
Copy Markdown
Contributor
  • use const and let instead of var
  • use arrow function
Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines
Affected core subsystem(s)

test

description

  • use const and let instead of var
  • use arrow function

test: refactor test-watch-file.js
f49e63e 
* use const and let instead of var
* use arrow function
nodejs-github-bot added test Issues and PRs related to the tests. dont-land-on-v7.x labels Jan 7, 2017
mscdex added fs Issues and PRs related to the fs subsystem / file system. and removed dont-land-on-v7.x labels Jan 7, 2017

sivaprs commented Jan 8, 2017

Copy link
Copy Markdown
Contributor Author

cc @thefourtheye

thefourtheye reviewed Jan 9, 2017
View reviewed changes
Comment thread test/pummel/test-watch-file.js Outdated
var f = path.join(common.fixturesDir, 'x.txt');
const f = path.join(common.fixturesDir, 'x.txt');

console.log('watching for changes of ' + f);

thefourtheye Jan 9, 2017

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Can you please remove console.logs in this file?

italoacasas commented Jan 9, 2017

Copy link
Copy Markdown

CI: https://ci.nodejs.org/job/node-test-pull-request/5766/console

jasnell pushed a commit that referenced this pull request Jan 10, 2017
test: refactor test-watch-file.js
a799854 
* use const and let instead of var
* use arrow function
* removed console.log statements

PR-URL: #10679
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Italo A. Casas <me@italoacasas.com>
Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>

jasnell commented Jan 10, 2017

Copy link
Copy Markdown
Member

Landed in a799854

jasnell closed this Jan 10, 2017
italoacasas pushed a commit to italoacasas/node that referenced this pull request Jan 18, 2017
test: refactor test-watch-file.js
b1bf481 
* use const and let instead of var
* use arrow function
* removed console.log statements

PR-URL: nodejs#10679
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Italo A. Casas <me@italoacasas.com>
Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
italoacasas pushed a commit to italoacasas/node that referenced this pull request Jan 23, 2017
test: refactor test-watch-file.js
d930716 
* use const and let instead of var
* use arrow function
* removed console.log statements

PR-URL: nodejs#10679
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Italo A. Casas <me@italoacasas.com>
Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
italoacasas pushed a commit to italoacasas/node that referenced this pull request Jan 25, 2017
test: refactor test-watch-file.js
d469965 
* use const and let instead of var
* use arrow function
* removed console.log statements

PR-URL: nodejs#10679
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Italo A. Casas <me@italoacasas.com>
Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
italoacasas mentioned this pull request Jan 25, 2017
Closed
italoacasas pushed a commit to italoacasas/node that referenced this pull request Jan 27, 2017
test: refactor test-watch-file.js
17d9a73 
* use const and let instead of var
* use arrow function
* removed console.log statements

PR-URL: nodejs#10679
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Italo A. Casas <me@italoacasas.com>
Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
italoacasas mentioned this pull request Jan 29, 2017
Merged
MylesBorins pushed a commit that referenced this pull request Mar 8, 2017
test: refactor test-watch-file.js
743bdf9 
* use const and let instead of var
* use arrow function
* removed console.log statements

PR-URL: #10679
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Italo A. Casas <me@italoacasas.com>
Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
MylesBorins pushed a commit that referenced this pull request Mar 8, 2017
test: refactor test-watch-file.js
803040c 
* use const and let instead of var
* use arrow function
* removed console.log statements

PR-URL: #10679
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Italo A. Casas <me@italoacasas.com>
Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
MylesBorins pushed a commit that referenced this pull request Mar 9, 2017
test: refactor test-watch-file.js
9acc86f 
* use const and let instead of var
* use arrow function
* removed console.log statements

PR-URL: #10679
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Italo A. Casas <me@italoacasas.com>
Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
MylesBorins mentioned this pull request Mar 9, 2017
Merged
MylesBorins pushed a commit that referenced this pull request Mar 9, 2017
test: refactor test-watch-file.js
ab65429 
* use const and let instead of var
* use arrow function
* removed console.log statements

PR-URL: #10679
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Italo A. Casas <me@italoacasas.com>
Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
MylesBorins mentioned this pull request Mar 9, 2017
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

jasnell jasnell approved these changes
lpinca lpinca approved these changes
cjihrig cjihrig approved these changes
+2 more reviewers
thefourtheye thefourtheye approved these changes
italoacasas italoacasas approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

fs Issues and PRs related to the fs subsystem / file system. test Issues and PRs related to the tests.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

9 participants

Back | FazBrowse Home | New Git URL