v7.x backport - doc: correct vcbuild options for windows testing - #10686
v7.x backport - doc: correct vcbuild options for windows testing#10686gibfahn wants to merge 1 commit into
Conversation
Sorry, something went wrong.
|
@jboarman I reopened your PR, the commit is still attributed to you, let me know if that's okay. |
Sorry, something went wrong.
|
@MylesBorins this needs to land on v7, v6, and v4 (but not master), should I retarget this PR to v7.x and then add the lts-watch labels for v4 and v6? EDIT: Did that, let me know if it's wrong... |
Sorry, something went wrong.
Sorry, something went wrong.
Corrected parameter for running tests on Windows. Without the corrected parameters, Windows users encounter an error about failing to sign the build, "Failed to sign exe", which can be discouraging to new Windows community members.
Corrected parameter for running tests on Windows. Without the corrected parameters, Windows users encounter an error about failing to sign the build, "Failed to sign exe", which can be discouraging to new Windows community members. PR-URL: #10686 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Bartosz Sosnowski <bartosz@janeasystems.com>
|
@jasnell it looks like ed9b6c1 landed in master? This is actually wrong in master, it was superseded in #10156 (but that was semver-major so didn't go into release lines). It needs to go into v7.x, v6.x, and v4.x (see #10686 (comment)). It's my bad, I should have put a big v7.x sign at the top of the PR. @nodejs/lts what do we do now? Do we revert this in master? |
Sorry, something went wrong.
|
aw dangit... I must have forgotten to switch branches. ok, thanks for spotting this. glad it wasn't something more substantial |
Sorry, something went wrong.
Corrected parameter for running tests on Windows. Without the corrected parameters, Windows users encounter an error about failing to sign the build, "Failed to sign exe", which can be discouraging to new Windows community members. PR-URL: nodejs#10686 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Bartosz Sosnowski <bartosz@janeasystems.com>
Corrected parameter for running tests on Windows. Without the corrected parameters, Windows users encounter an error about failing to sign the build, "Failed to sign exe", which can be discouraging to new Windows community members. PR-URL: nodejs#10686 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Bartosz Sosnowski <bartosz@janeasystems.com>
Corrected parameter for running tests on Windows. Without the corrected parameters, Windows users encounter an error about failing to sign the build, "Failed to sign exe", which can be discouraging to new Windows community members. PR-URL: nodejs#10686 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Bartosz Sosnowski <bartosz@janeasystems.com>
Corrected parameter for running tests on Windows. Without the corrected parameters, Windows users encounter an error about failing to sign the build, "Failed to sign exe", which can be discouraging to new Windows community members. PR-URL: nodejs#10686 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Bartosz Sosnowski <bartosz@janeasystems.com>
|
This has landed correctly in v7.x-staging and was correctly reverted in master. But still needs to land in v4.x-staging and v6.x-staging. Since this is approved, I'll just cherry-pick the commit to those branches. I'll do this tomorrow to give @nodejs/lts a chance to stop me if this is not correct or should be done in some other way. |
Sorry, something went wrong.
|
@joaocgreis please hold off on backporting to staging. We generally don't land anything until it has lived in master for at least two weeks. We are also mid release cycle, so anything on staging will need to be rebased. If you want to guarantee that specific commits land together I suggest opening a backport PR |
Sorry, something went wrong.
|
@MylesBorins this is a docs-only bugfix PR, which also only affects people building from source on Windows (it only changes BUILDING.md and CONTRIBUTING.md). Does it still need to wait for two weeks? |
Sorry, something went wrong.
|
Ah, didn't realize it was docs only... backport away, I can wrap it into the next release |
Sorry, something went wrong.
Corrected parameter for running tests on Windows. Without the corrected parameters, Windows users encounter an error about failing to sign the build, "Failed to sign exe", which can be discouraging to new Windows community members. PR-URL: #10686 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Bartosz Sosnowski <bartosz@janeasystems.com>
Corrected parameter for running tests on Windows. Without the corrected parameters, Windows users encounter an error about failing to sign the build, "Failed to sign exe", which can be discouraging to new Windows community members. PR-URL: #10686 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Bartosz Sosnowski <bartosz@janeasystems.com>
|
Landed in v4.x-staging in 6034bdc . I believe we now have this correct in all branches. |
Sorry, something went wrong.
Corrected parameter for running tests on Windows. Without the corrected parameters, Windows users encounter an error about failing to sign the build, "Failed to sign exe", which can be discouraging to new Windows community members. PR-URL: #10686 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Bartosz Sosnowski <bartosz@janeasystems.com>
Corrected parameter for running tests on Windows. Without the corrected parameters, Windows users encounter an error about failing to sign the build, "Failed to sign exe", which can be discouraging to new Windows community members. PR-URL: #10686 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Bartosz Sosnowski <bartosz@janeasystems.com>
Corrected parameter for running tests on Windows. Without the corrected
parameters, Windows users encounter an error about failing to sign the
build, "Failed to sign exe", which can be discouraging to new Windows
community members.
Reopened version of #10112, I added .\ and changed test nosign->nosign test as per comments in that PR (and also change commit message to be <50 chars).
Checklist
Affected core subsystem(s)
doc, win