FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

doc: fix misleading language in vm docs by aqrln · Pull Request #10708 · nodejs/node · GitHub

/ node Public

doc: fix misleading language in vm docs - #10708

Closed
aqrln wants to merge 1 commit into
nodejs:masterfrom
aqrln:vm-doc-context
ConversationCommits (1)ChecksFiles changed
Closed

doc: fix misleading language in vm docs#10708
aqrln wants to merge 1 commit into
nodejs:masterfrom
aqrln:vm-doc-context

Conversation

aqrln commented Jan 9, 2017

Copy link
Copy Markdown
Contributor

As @mscdex noted, the note following the http.Server example in the vm documentation contains misleading language. This commit removes the incorrect reference to threads.

Fixes: #10697

Checklist
  • documentation is changed or added
  • commit message follows commit guidelines
Affected core subsystem(s)

doc

nodejs-github-bot added doc Issues and PRs related to the documentations. vm Issues and PRs related to the vm subsystem. lts-watch-v6.x labels Jan 9, 2017
mscdex reviewed Jan 9, 2017
View reviewed changes
Comment thread doc/api/vm.md Outdated

mscdex Jan 9, 2017

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Perhaps s/from/in/ ?

aqrln Jan 9, 2017 •
edited
Loading

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

I didn't change this sentence (except the addition of an article), but I think the author meant that require had been passed from the other context. However, it would be nice to reword the whole sentence, since there are some other quirks; e.g., why "shares the state with the context" if it just shares the same context.

aqrln Jan 9, 2017

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

@mscdex ah, sorry, we are talking about different lines.

aqrln Jan 9, 2017

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Yes, "in" should be used here.

aqrln commented Jan 9, 2017

Copy link
Copy Markdown
Contributor Author

@mscdex I've pushed a new commit. What about the line I've confused one you were talking about with, I think it's pretty okay though not perfect and I don't see a better way to reword it now.

mscdex commented Jan 9, 2017 •
edited
Loading

Copy link
Copy Markdown
Contributor

LGTM.

@aqrln The rest is fine I think for now.

doc: fix misleading language in vm docs
4bda875 
The note following the http.Server example in the vm documentation
contains misleading language. This commit removes the incorrect
reference to threads.

Fixes: nodejs#10697

aqrln commented Jan 11, 2017

Copy link
Copy Markdown
Contributor Author

@jasnell @mscdex I've updated the commit message so that it includes the full URL in the 'Fixes:' field, not just issue number.

mscdex commented Jan 11, 2017

Copy link
Copy Markdown
Contributor

Landed in 8781e61. Thanks!

mscdex closed this Jan 11, 2017
mscdex pushed a commit that referenced this pull request Jan 11, 2017
doc: fix misleading language in vm docs
8781e61 
The note following the http.Server example in the vm documentation
contains misleading language. This commit removes the incorrect
reference to threads.

Fixes: #10697
PR-URL: #10708
Reviewed-By: Brian White <mscdex@mscdex.net>
Reviewed-By: James M Snell <jasnell@gmail.com>
italoacasas pushed a commit to italoacasas/node that referenced this pull request Jan 18, 2017
doc: fix misleading language in vm docs
1b7bcec 
The note following the http.Server example in the vm documentation
contains misleading language. This commit removes the incorrect
reference to threads.

Fixes: nodejs#10697
PR-URL: nodejs#10708
Reviewed-By: Brian White <mscdex@mscdex.net>
Reviewed-By: James M Snell <jasnell@gmail.com>
italoacasas pushed a commit to italoacasas/node that referenced this pull request Jan 23, 2017
doc: fix misleading language in vm docs
0a548dc 
The note following the http.Server example in the vm documentation
contains misleading language. This commit removes the incorrect
reference to threads.

Fixes: nodejs#10697
PR-URL: nodejs#10708
Reviewed-By: Brian White <mscdex@mscdex.net>
Reviewed-By: James M Snell <jasnell@gmail.com>
italoacasas pushed a commit to italoacasas/node that referenced this pull request Jan 24, 2017
doc: fix misleading language in vm docs
8ca4990 
The note following the http.Server example in the vm documentation
contains misleading language. This commit removes the incorrect
reference to threads.

Fixes: nodejs#10697
PR-URL: nodejs#10708
Reviewed-By: Brian White <mscdex@mscdex.net>
Reviewed-By: James M Snell <jasnell@gmail.com>
italoacasas mentioned this pull request Jan 25, 2017
Closed
italoacasas pushed a commit to italoacasas/node that referenced this pull request Jan 27, 2017
doc: fix misleading language in vm docs
9b73a85 
The note following the http.Server example in the vm documentation
contains misleading language. This commit removes the incorrect
reference to threads.

Fixes: nodejs#10697
PR-URL: nodejs#10708
Reviewed-By: Brian White <mscdex@mscdex.net>
Reviewed-By: James M Snell <jasnell@gmail.com>
italoacasas mentioned this pull request Jan 29, 2017
Merged
MylesBorins pushed a commit that referenced this pull request Mar 7, 2017
doc: fix misleading language in vm docs
a39830a 
The note following the http.Server example in the vm documentation
contains misleading language. This commit removes the incorrect
reference to threads.

Fixes: #10697
PR-URL: #10708
Reviewed-By: Brian White <mscdex@mscdex.net>
Reviewed-By: James M Snell <jasnell@gmail.com>
MylesBorins pushed a commit that referenced this pull request Mar 9, 2017
doc: fix misleading language in vm docs
494ee51 
The note following the http.Server example in the vm documentation
contains misleading language. This commit removes the incorrect
reference to threads.

Fixes: #10697
PR-URL: #10708
Reviewed-By: Brian White <mscdex@mscdex.net>
Reviewed-By: James M Snell <jasnell@gmail.com>
MylesBorins mentioned this pull request Mar 9, 2017
Merged
aqrln deleted the vm-doc-context branch March 10, 2017 04:20
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

jasnell jasnell approved these changes
+1 more reviewer
mscdex mscdex left review comments
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

doc Issues and PRs related to the documentations. vm Issues and PRs related to the vm subsystem.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

Back | FazBrowse Home | New Git URL