FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

(backport) src/doc: improve man page and --help by silverwind · Pull Request #10730 · nodejs/node · GitHub

/ node Public

(backport) src/doc: improve man page and --help - #10730

Closed
silverwind wants to merge 1 commit into
nodejs:v7.x-stagingfrom
silverwind:backport-10157
ConversationCommits (1)ChecksFiles changed
Closed

(backport) src/doc: improve man page and --help#10730
silverwind wants to merge 1 commit into
nodejs:v7.x-stagingfrom
silverwind:backport-10157

Conversation

silverwind commented Jan 10, 2017 •
edited
Loading

Copy link
Copy Markdown
Contributor

Backport of #10157 to v7.x-staging. cc: @evanlucas

nodejs-github-bot added c++ Issues and PRs that require attention from people who are familiar with C++. v7.x labels Jan 10, 2017
evanlucas suggested changes Jan 10, 2017
View reviewed changes
Comment thread doc/node.1 Outdated

evanlucas Jan 10, 2017

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

we don't have this flag on v7.x

silverwind Jan 10, 2017

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

whoops, missed to remove these here, will fix.

Comment thread doc/node.1 Outdated

evanlucas Jan 10, 2017

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

we don't have this flag either

jasnell Jan 10, 2017

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

doh! you're right! good catch

src/doc: improve man page and --help
ee62961 
- add missing environment variables to --help
- add missing flags to man page
- sort environment variables alphabetically
- add some highlighting to the man page
- remove stops from descriptions in --help for consistency
- few other minor tweaks to --help

PR-URL: nodejs#10157
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Italo A. Casas <me@italoacasas.com>
Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>

silverwind commented Jan 10, 2017

Copy link
Copy Markdown
Contributor Author

Fixed, thanks.

evanlucas approved these changes Jan 11, 2017
View reviewed changes

evanlucas left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

LGTM. Thanks!

silverwind changed the title src/doc: improve man page and --help (backport) src/doc: improve man page and --help Jan 12, 2017
jasnell reviewed Jan 12, 2017
View reviewed changes
Comment thread doc/node.1
.TP
.BR NODE_DISABLE_COLORS=1
When set to 1 colors will not be used in the REPL.
.BR NODE_EXTRA_CA_CERTS =\fIfile\fR

jasnell Jan 12, 2017

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

has this actually landed in v7 yet?

silverwind Jan 13, 2017

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

It's in v7.x-staging at least:

node/src/node.cc

Line 4539 in e07b651

if (const char* extra = secure_getenv("NODE_EXTRA_CA_CERTS"))

sam-github Jan 13, 2017

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Also in v7.x branch.

silverwind commented Jan 16, 2017

Copy link
Copy Markdown
Contributor Author

Landed on v7.x-staging: 61f6f12.

silverwind closed this Jan 16, 2017
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

jasnell jasnell approved these changes
+2 more reviewers
sam-github sam-github approved these changes
evanlucas evanlucas approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

c++ Issues and PRs that require attention from people who are familiar with C++.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

Back | FazBrowse Home | New Git URL