FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

test: improve the code in test-crypto-dh by edsadr · Pull Request #10734 · nodejs/node · GitHub

/ node Public

test: improve the code in test-crypto-dh - #10734

Closed
edsadr wants to merge 1 commit into
nodejs:masterfrom
edsadr:crypto-dh
ConversationCommits (1)ChecksFiles changed
Closed

test: improve the code in test-crypto-dh#10734
edsadr wants to merge 1 commit into
nodejs:masterfrom
edsadr:crypto-dh

Conversation

edsadr commented Jan 11, 2017 •
edited
Loading

Copy link
Copy Markdown
Contributor
  • validate the errors for some assert.throws
  • use arrow functions
Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • commit message follows commit guidelines
Affected core subsystem(s)

test

nodejs-github-bot added test Issues and PRs related to the tests. lts-watch-v6.x labels Jan 11, 2017
mscdex added the crypto Issues and PRs related to the crypto subsystem. label Jan 11, 2017
lpinca reviewed Jan 11, 2017
View reviewed changes
Comment thread test/parallel/test-crypto-dh.js Outdated

lpinca Jan 11, 2017 •
edited
Loading

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Nit: can the regex be updated to include ^ and $ anchors?

cjihrig requested changes Jan 11, 2017
View reviewed changes
Comment thread test/parallel/test-crypto-dh.js Outdated

cjihrig Jan 11, 2017

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

This line should be indented more.

edsadr commented Jan 12, 2017

Copy link
Copy Markdown
Contributor Author

@cjihrig, @lpinca did the changes, please check

cjihrig commented Jan 12, 2017

Copy link
Copy Markdown
Contributor

This has conflicts that need to be resolved.

edsadr commented Jan 12, 2017

Copy link
Copy Markdown
Contributor Author

@cjihrig solved those conflicts

mscdex mentioned this pull request Jan 12, 2017
Closed
4 tasks
fluxsauce reviewed Jan 12, 2017
View reviewed changes
Comment thread test/parallel/test-crypto-dh.js Outdated

fluxsauce Jan 12, 2017

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

index and object are not used; they were excluded in #10753 (didn't realize this PR existed). Can you remove?

edsadr Jan 12, 2017 •
edited
Loading

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

sure thing @fluxsauce, I am changing this now

test: improve the code in test-crypto-dh
e2c8c3c 
* validate the errors for all assert.throws
* use arrow functions
lpinca reviewed Jan 12, 2017
View reviewed changes
Comment thread test/parallel/test-crypto-dh.js
assert.strictEqual(secret1, secret3);

const wrongBlockLength =
new RegExp('^Error: error:0606506D:digital envelope' +

lpinca Jan 12, 2017

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Nit: this indentation looks a bit weird, why 4 spaces?

gibfahn Jan 12, 2017

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

See discussion here. I thought it was 4 spaces (otherwise two would get confused with indentation), but I'm not sure what the consensus is.

lpinca Jan 12, 2017

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Hmm ok, thanks @gibfahn.

edsadr Jan 12, 2017 •
edited
Loading

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

@lpinca, looks like we really need this code style defined, the linter is not effective enough to solve these questions and the answer differs among collaborators

lpinca Jan 12, 2017

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Yes, I agree.

lpinca commented Jan 12, 2017

Copy link
Copy Markdown
Member

CI: https://ci.nodejs.org/job/node-test-pull-request/5825/

mhdawson approved these changes Jan 12, 2017
View reviewed changes

mhdawson left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

LGTM

jasnell pushed a commit that referenced this pull request Jan 13, 2017
test: improve the code in test-crypto-dh
5520e40 
* validate the errors for all assert.throws
* use arrow functions

PR-URL: #10734
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>

jasnell commented Jan 13, 2017

Copy link
Copy Markdown
Member

Landed in 5520e40

jasnell closed this Jan 13, 2017
italoacasas pushed a commit to italoacasas/node that referenced this pull request Jan 18, 2017
test: improve the code in test-crypto-dh
0612383 
* validate the errors for all assert.throws
* use arrow functions

PR-URL: nodejs#10734
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
This was referenced Jan 19, 2017
Closed
Closed
targos pushed a commit that referenced this pull request Jan 28, 2017
test: improve the code in test-crypto-dh
3e1c2d4 
* validate the errors for all assert.throws
* use arrow functions

PR-URL: #10734
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
italoacasas mentioned this pull request Jan 29, 2017
Merged
italoacasas pushed a commit to italoacasas/node that referenced this pull request Jan 30, 2017
test: improve the code in test-crypto-dh
4a7bb5b 
* validate the errors for all assert.throws
* use arrow functions

PR-URL: nodejs#10734
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
italoacasas pushed a commit to italoacasas/node that referenced this pull request Jan 30, 2017
test: improve the code in test-crypto-dh
102a73d 
* validate the errors for all assert.throws
* use arrow functions

PR-URL: nodejs#10734
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>

jasnell commented Mar 8, 2017

Copy link
Copy Markdown
Member

This will need backport PRs in order to land in v6 or v4

targos mentioned this pull request Jun 19, 2017
Closed
2 tasks
gibfahn pushed a commit that referenced this pull request Jun 19, 2017
test: improve the code in test-crypto-dh
8dab28d 
* validate the errors for all assert.throws
* use arrow functions

PR-URL: #10734
Backport-PR-URL: #13785
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
gibfahn pushed a commit that referenced this pull request Jun 20, 2017
test: improve the code in test-crypto-dh
11cb4d0 
* validate the errors for all assert.throws
* use arrow functions

PR-URL: #10734
Backport-PR-URL: #13785
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
MylesBorins pushed a commit that referenced this pull request Jul 11, 2017
test: improve the code in test-crypto-dh
bab8a36 
* validate the errors for all assert.throws
* use arrow functions

PR-URL: #10734
Backport-PR-URL: #13785
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
MylesBorins mentioned this pull request Jul 18, 2017
Merged
abhishekumar-tyagi pushed a commit to abhishekumar-tyagi/node that referenced this pull request May 5, 2024
test: improve the code in test-crypto-dh
15b4be8 
* validate the errors for all assert.throws
* use arrow functions

PR-URL: nodejs/node#10734
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

lpinca lpinca approved these changes
jasnell jasnell approved these changes
cjihrig cjihrig approved these changes
+3 more reviewers
fluxsauce fluxsauce left review comments
gibfahn gibfahn left review comments
mhdawson mhdawson approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

crypto Issues and PRs related to the crypto subsystem. test Issues and PRs related to the tests.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

9 participants

Back | FazBrowse Home | New Git URL