FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

test: move resource intensive test to sequential by Trott · Pull Request #10744 · nodejs/node · GitHub

/ node Public

test: move resource intensive test to sequential - #10744

Closed
Trott wants to merge 1 commit into
nodejs:masterfrom
Trott:fileread-seq
ConversationCommits (1)ChecksFiles changed
Closed

test: move resource intensive test to sequential#10744
Trott wants to merge 1 commit into
nodejs:masterfrom
Trott:fileread-seq

Conversation

Trott commented Jan 11, 2017

Copy link
Copy Markdown
Member

test-fs-readfile-tostring-fail is resource-intensive and is flaky in
CI. Move to sequential tests so it is not competing for resources with
other tests.

Fixes: #10742

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines
Affected core subsystem(s)

test fs

test: move resource intensive test to sequential
4abe302 
test-fs-readfile-tostring-fail is resource-intensive and is flaky in
CI. Move to sequential tests so it is not competing for resources with
other tests.

Fixes: nodejs#10742
nodejs-github-bot added test Issues and PRs related to the tests. dont-land-on-v7.x labels Jan 11, 2017

Trott commented Jan 11, 2017

Copy link
Copy Markdown
Member Author

Sample failure of existing test in CI:

https://ci.nodejs.org/job/node-test-commit-osx/7145/nodes=osx1010/console

not ok 405 parallel/test-fs-readfile-tostring-fail
  ---
  duration_ms: 60.203
  severity: fail
  stack: |-
    timeout

Trott commented Jan 11, 2017

Copy link
Copy Markdown
Member Author

CI stress test 32 simultaneous runs of existing parallel test failing:
https://ci.nodejs.org/job/node-stress-single-test/1101/nodes=osx1010/console

CI stress test same thing but in sequential succeeding:
https://ci.nodejs.org/job/node-stress-single-test/1102/nodes=osx1010/console

Trott commented Jan 11, 2017

Copy link
Copy Markdown
Member Author

CI: https://ci.nodejs.org/job/node-test-commit/7176/

Trott commented Jan 11, 2017

Copy link
Copy Markdown
Member Author

/cc @nodejs/testing @mscdex

mscdex commented Jan 11, 2017

Copy link
Copy Markdown
Contributor

LGTM

mscdex added fs Issues and PRs related to the fs subsystem / file system. and removed dont-land-on-v7.x labels Jan 11, 2017

santigimeno commented Jan 11, 2017

Copy link
Copy Markdown
Member

LGTM

mhdawson approved these changes Jan 11, 2017
View reviewed changes

mhdawson left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

LGTM

Trott commented Jan 12, 2017

Copy link
Copy Markdown
Member Author

Anyone on board with a "this is trivial and doesn't need to wait 48 hours" for this?

Trott added a commit to Trott/io.js that referenced this pull request Jan 12, 2017
test: move resource intensive test to sequential
d3eca02 
test-fs-readfile-tostring-fail is resource-intensive and is flaky in
CI. Move to sequential tests so it is not competing for resources with
other tests.

PR-URL: nodejs#10744
Fixes: nodejs#10742
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
Reviewed-By: Brian White <mscdex@mscdex.net>
Reviewed-By: Santiago Gimeno <santiago.gimeno@gmail.com>

Trott commented Jan 12, 2017

Copy link
Copy Markdown
Member Author

Landed in d3eca02.

Trott closed this Jan 12, 2017
italoacasas pushed a commit to italoacasas/node that referenced this pull request Jan 18, 2017
test: move resource intensive test to sequential
48c320a 
test-fs-readfile-tostring-fail is resource-intensive and is flaky in
CI. Move to sequential tests so it is not competing for resources with
other tests.

PR-URL: nodejs#10744
Fixes: nodejs#10742
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
Reviewed-By: Brian White <mscdex@mscdex.net>
Reviewed-By: Santiago Gimeno <santiago.gimeno@gmail.com>
italoacasas pushed a commit to italoacasas/node that referenced this pull request Jan 23, 2017
test: move resource intensive test to sequential
2199033 
test-fs-readfile-tostring-fail is resource-intensive and is flaky in
CI. Move to sequential tests so it is not competing for resources with
other tests.

PR-URL: nodejs#10744
Fixes: nodejs#10742
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
Reviewed-By: Brian White <mscdex@mscdex.net>
Reviewed-By: Santiago Gimeno <santiago.gimeno@gmail.com>
italoacasas pushed a commit to italoacasas/node that referenced this pull request Jan 25, 2017
test: move resource intensive test to sequential
ab1b709 
test-fs-readfile-tostring-fail is resource-intensive and is flaky in
CI. Move to sequential tests so it is not competing for resources with
other tests.

PR-URL: nodejs#10744
Fixes: nodejs#10742
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
Reviewed-By: Brian White <mscdex@mscdex.net>
Reviewed-By: Santiago Gimeno <santiago.gimeno@gmail.com>
italoacasas mentioned this pull request Jan 25, 2017
Closed
italoacasas pushed a commit to italoacasas/node that referenced this pull request Jan 27, 2017
test: move resource intensive test to sequential
30926ac 
test-fs-readfile-tostring-fail is resource-intensive and is flaky in
CI. Move to sequential tests so it is not competing for resources with
other tests.

PR-URL: nodejs#10744
Fixes: nodejs#10742
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
Reviewed-By: Brian White <mscdex@mscdex.net>
Reviewed-By: Santiago Gimeno <santiago.gimeno@gmail.com>
italoacasas mentioned this pull request Jan 29, 2017
Merged
MylesBorins pushed a commit that referenced this pull request Mar 8, 2017
test: move resource intensive test to sequential
4e1642f 
test-fs-readfile-tostring-fail is resource-intensive and is flaky in
CI. Move to sequential tests so it is not competing for resources with
other tests.

PR-URL: #10744
Fixes: #10742
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
Reviewed-By: Brian White <mscdex@mscdex.net>
Reviewed-By: Santiago Gimeno <santiago.gimeno@gmail.com>
MylesBorins pushed a commit that referenced this pull request Mar 9, 2017
test: move resource intensive test to sequential
5d0cc61 
test-fs-readfile-tostring-fail is resource-intensive and is flaky in
CI. Move to sequential tests so it is not competing for resources with
other tests.

PR-URL: #10744
Fixes: #10742
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
Reviewed-By: Brian White <mscdex@mscdex.net>
Reviewed-By: Santiago Gimeno <santiago.gimeno@gmail.com>
MylesBorins mentioned this pull request Mar 9, 2017
Merged
Trott deleted the fileread-seq branch January 13, 2022 22:45
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

jasnell jasnell approved these changes
cjihrig cjihrig approved these changes
+2 more reviewers
mhdawson mhdawson approved these changes
gibfahn gibfahn approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

fs Issues and PRs related to the fs subsystem / file system. test Issues and PRs related to the tests.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Investigate flaky test-fs-readfile-tostring-fail on macOS

9 participants

Back | FazBrowse Home | New Git URL