deps: upgrade npm to 4.1.1 - #10781
Closed
iarna wants to merge 1 commit into
Closed
Conversation
Copy link
Copy Markdown
Member
Sorry, something went wrong.
Copy link
Copy Markdown
Member
|
Will be able to give this a more thorough review later on but just quickly on the file URL bit... once the new WHATWG URL stuff moves out of experimental, it's handling of file:// URL parsing would be considered canonical. (I am currently considering a proposal to backport the new parser to v6 and v4) |
Sorry, something went wrong.
Fishrock123
approved these changes
Jan 13, 2017
Fishrock123
left a comment
Copy link
Copy Markdown
Contributor
There was a problem hiding this comment.
npm tests pass
Sorry, something went wrong.
Copy link
Copy Markdown
Contributor
|
Oops, forgot to merge this. D: Doing it now! |
Sorry, something went wrong.
Fishrock123
pushed a commit
that referenced
this pull request
Jan 26, 2017
PR-URL: #10781 Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>
targos
pushed a commit
that referenced
this pull request
Jan 28, 2017
PR-URL: #10781 Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>
Merged
italoacasas
pushed a commit
to italoacasas/node
that referenced
this pull request
Jan 30, 2017
PR-URL: nodejs#10781 Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>
italoacasas
pushed a commit
to italoacasas/node
that referenced
this pull request
Jan 30, 2017
PR-URL: nodejs#10781 Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
1 more reviewer4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist
Affected core subsystem(s)
Description of change
Changelogs
r: @Fishrock123
r: @addaleax
r: @jasnell