FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

test: testing noAssert in buffer.write() by larissayvette · Pull Request #10790 · nodejs/node · GitHub

/ node Public

test: testing noAssert in buffer.write() - #10790

Closed
larissayvette wants to merge 1 commit into
nodejs:masterfrom
larissayvette:test-write
ConversationCommits (1)ChecksFiles changed
Closed

test: testing noAssert in buffer.write()#10790
larissayvette wants to merge 1 commit into
nodejs:masterfrom
larissayvette:test-write

Conversation

larissayvette commented Jan 13, 2017 •
edited
Loading

Copy link
Copy Markdown
Contributor
Checklist
  • commit message follows commit guidelines
Affected core subsystem(s)

test

Test for noAssert in buffer.write() files and inluded buffer.writeDouble* and buffer.writeFloat* as it was not present in the first commit

nodejs-github-bot added test Issues and PRs related to the tests. lts-watch-v6.x labels Jan 13, 2017
mscdex added the buffer Issues and PRs related to the buffer subsystem. label Jan 13, 2017

Trott commented Jan 13, 2017

Copy link
Copy Markdown
Member

buffer.writeDouble* and buffer.writeFloat*

You should be able to run these tests for those functions as well. The issue with those functions will only manifest if you request something out of range. Since this test requests valid ranges with noAssert enabled, it should be OK.

larissayvette commented Jan 14, 2017

Copy link
Copy Markdown
Contributor Author

@Trott included those test cases buffer.writeDouble* and buffer.writeFloat*

Trott approved these changes Jan 14, 2017
View reviewed changes

Trott left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

LGTM if CI is green

Trott commented Jan 14, 2017

Copy link
Copy Markdown
Member

CI: https://ci.nodejs.org/job/node-test-pull-request/5857/

thefourtheye reviewed Jan 14, 2017
View reviewed changes
Comment thread test/parallel/test-buffer-write-noassert.js Outdated

thefourtheye Jan 14, 2017

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

This functionality is tested every time. Wouldn't it be enough to test this only once?

Trott Jan 14, 2017

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Oh, yes, that's testing the wrong thing. It should test a legit alloc() call and an out-of-range call to the write function being tested. @larissayvette can you adjust it?

Trott commented Jan 26, 2017

Copy link
Copy Markdown
Member

Changes LGTM

Trott commented Jan 26, 2017

Copy link
Copy Markdown
Member

New CI: https://ci.nodejs.org/job/node-test-pull-request/6075/

Trott commented Jan 26, 2017

Copy link
Copy Markdown
Member

Single failure on SmartOS is unrelated, opened an issue for it.

Trott pushed a commit to Trott/io.js that referenced this pull request Jan 26, 2017
test: check noAssert option in buf.write*()
084acc8 
Add test to cover previously untested `noAssert` functionality in
buf.write*() functions.

PR-URL: nodejs#10790
Reviewed-By: Rich Trott <rtrott@gmail.com>

Trott commented Jan 26, 2017

Copy link
Copy Markdown
Member

Landed in 084acc8.
Thanks for the contribution! 🎉

Trott closed this Jan 26, 2017
evanlucas pushed a commit that referenced this pull request Jan 31, 2017
test: check noAssert option in buf.write*()
c1e166a 
Add test to cover previously untested `noAssert` functionality in
buf.write*() functions.

PR-URL: #10790
Reviewed-By: Rich Trott <rtrott@gmail.com>
italoacasas mentioned this pull request Jan 31, 2017
Merged
larissayvette deleted the test-write branch February 10, 2017 17:42
jasnell pushed a commit that referenced this pull request Mar 8, 2017
test: check noAssert option in buf.write*()
a9acc2f 
Add test to cover previously untested `noAssert` functionality in
buf.write*() functions.

PR-URL: #10790
Reviewed-By: Rich Trott <rtrott@gmail.com>

jasnell commented Mar 8, 2017

Copy link
Copy Markdown
Member

This would need a backport PR to land in v4

MylesBorins pushed a commit that referenced this pull request Mar 9, 2017
test: check noAssert option in buf.write*()
a175186 
Add test to cover previously untested `noAssert` functionality in
buf.write*() functions.

PR-URL: #10790
Reviewed-By: Rich Trott <rtrott@gmail.com>
MylesBorins mentioned this pull request Mar 9, 2017
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

Trott Trott approved these changes
+1 more reviewer
thefourtheye thefourtheye left review comments
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

buffer Issues and PRs related to the buffer subsystem. test Issues and PRs related to the tests.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

Back | FazBrowse Home | New Git URL