test: fix broken assertion - #10840
Closed
cjihrig wants to merge 1 commit into
Closed
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
3 tasks
Copy link
Copy Markdown
Contributor
Author
|
CI: https://ci.nodejs.org/job/node-test-pull-request/5893/ Trying again: https://ci.nodejs.org/job/node-test-pull-request/5899/ |
Sorry, something went wrong.
italoacasas
approved these changes
Jan 16, 2017
This commit fixes a broken assertion in test-cli-eval.js.
jasnell
approved these changes
Jan 16, 2017
Copy link
Copy Markdown
Contributor
Author
|
CI is green. May want to fast track this to unbreak the CI. |
Sorry, something went wrong.
Copy link
Copy Markdown
|
+1 for fast tracking this |
Sorry, something went wrong.
addaleax
approved these changes
Jan 17, 2017
addaleax
left a comment
Copy link
Copy Markdown
Member
There was a problem hiding this comment.
LGTM, landing
Sorry, something went wrong.
addaleax
pushed a commit
that referenced
this pull request
Jan 17, 2017
This commit fixes a broken assertion in test-cli-eval.js. PR-URL: #10840 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Italo A. Casas <me@italoacasas.com> Reviewed-By: Anna Henningsen <anna@addaleax.net>
Copy link
Copy Markdown
Member
|
btw, my apologies on this. I'd completely missed the breakage there somehow. |
Sorry, something went wrong.
italoacasas
pushed a commit
to italoacasas/node
that referenced
this pull request
Jan 18, 2017
This commit fixes a broken assertion in test-cli-eval.js. PR-URL: nodejs#10840 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Italo A. Casas <me@italoacasas.com> Reviewed-By: Anna Henningsen <anna@addaleax.net>
targos
pushed a commit
that referenced
this pull request
Jan 28, 2017
This commit fixes a broken assertion in test-cli-eval.js. PR-URL: #10840 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Italo A. Casas <me@italoacasas.com> Reviewed-By: Anna Henningsen <anna@addaleax.net>
Merged
italoacasas
pushed a commit
to italoacasas/node
that referenced
this pull request
Jan 30, 2017
This commit fixes a broken assertion in test-cli-eval.js. PR-URL: nodejs#10840 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Italo A. Casas <me@italoacasas.com> Reviewed-By: Anna Henningsen <anna@addaleax.net>
italoacasas
pushed a commit
to italoacasas/node
that referenced
this pull request
Jan 30, 2017
This commit fixes a broken assertion in test-cli-eval.js. PR-URL: nodejs#10840 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Italo A. Casas <me@italoacasas.com> Reviewed-By: Anna Henningsen <anna@addaleax.net>
MylesBorins
pushed a commit
that referenced
this pull request
Apr 18, 2017
This commit fixes a broken assertion in test-cli-eval.js. PR-URL: #10840 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Italo A. Casas <me@italoacasas.com> Reviewed-By: Anna Henningsen <anna@addaleax.net>
MylesBorins
pushed a commit
that referenced
this pull request
Apr 19, 2017
This commit fixes a broken assertion in test-cli-eval.js. PR-URL: #10840 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Italo A. Casas <me@italoacasas.com> Reviewed-By: Anna Henningsen <anna@addaleax.net>
Merged
andrew749
pushed a commit
to michielbaird/node
that referenced
this pull request
Jul 19, 2017
This commit fixes a broken assertion in test-cli-eval.js. PR-URL: nodejs/node#10840 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Italo A. Casas <me@italoacasas.com> Reviewed-By: Anna Henningsen <anna@addaleax.net>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
8 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This commit fixes a broken assertion in test-cli-eval.js. b9adbf2 introduced the break, and was landed even though CI showed that the test failed.
Checklist
Affected core subsystem(s)
test