| FazBrowse GitHub Viewer | Trending | | Home |
| Tools: [Download Repo ZIP] [Original HTTPS Page] |
There was a problem hiding this comment.
Super tiny nit: can you add a final dot?
Sorry, something went wrong.
There was a problem hiding this comment.
@lpinca done. ;)
Sorry, something went wrong.
|
Might be worthwhile mentioning that the Moderation Repo details are confidential and should not be shared externally |
Sorry, something went wrong.
|
I don't believe this one needs to wait the full 48 hours to land |
Sorry, something went wrong.
I’d prefer to wait, tbh… maybe other people have valid points like yours. We have one onboarding scheduled for today and @Trott can probably bring it up “manually” ;) |
Sorry, something went wrong.
|
I prefer that the wording make it more clear that the people who have access to the repository number hundreds and are not merely the collaborators team. The way it is now, someone might think it's more private than it really is. |
Sorry, something went wrong.
|
@Trott Updated, how does this wording work for you? I can include an actual number if you’d like to be even more explicit about it. |
Sorry, something went wrong.
|
@addaleax That looks good to me. Maybe this might be even a bit better?:
|
Sorry, something went wrong.
|
@Trott your phrasing works for me, too … updated :) |
Sorry, something went wrong.
PR-URL: #10869 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Evan Lucas <evanlucas@me.com>
PR-URL: nodejs#10869 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Evan Lucas <evanlucas@me.com>
PR-URL: nodejs#10869 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Evan Lucas <evanlucas@me.com>
PR-URL: #10869 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Evan Lucas <evanlucas@me.com>
PR-URL: #10869 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Evan Lucas <evanlucas@me.com>
| Back | FazBrowse Home | New Git URL |
What it says in the PR title. ;)