FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

inspector: no crash when WS server can't start by eugeneo · Pull Request #10878 · nodejs/node · GitHub

/ node Public

inspector: no crash when WS server can't start - #10878

Merged
eugeneo merged 1 commit into
nodejs:masterfrom
eugeneo:no-assert
Jan 20, 2017
ConversationCommits (1)ChecksFiles changed
Merged

inspector: no crash when WS server can't start#10878
eugeneo merged 1 commit into
nodejs:masterfrom
eugeneo:no-assert

Conversation

eugeneo commented Jan 18, 2017

Copy link
Copy Markdown
Contributor

This change also changes error message to make it consistent with the
one printed by the debugger.

Fixes: #10858

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines
Affected core subsystem(s)

inspector: now it uses host name from the debug options. Messages were slightly altered.

nodejs-github-bot added c++ Issues and PRs that require attention from people who are familiar with C++. dont-land-on-v4.x inspector Issues and PRs related to the V8 inspector protocol labels Jan 18, 2017
bnoordhuis approved these changes Jan 18, 2017
View reviewed changes

bnoordhuis left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

LGTM. This doesn't change the default behavior of binding to 127.0.0.1, does it?

eugeneo commented Jan 18, 2017

Copy link
Copy Markdown
Contributor Author

@bnoordhuis - it will bind to 127.0.0.1 as per https://github.com/nodejs/node/blob/master/src/node_debug_options.cc#L62 - the fact that host was hardcoded was an oversight.

eugeneo commented Jan 19, 2017

Copy link
Copy Markdown
Contributor Author

CI is green - https://ci.nodejs.org/job/node-test-pull-request/5939/ - even though the GitHub integration shows failure on ARM...

inspector: no crash when WS server can't start
ba776b3 
This change also changes error message to make it consistent with the
one printed by the debugger.

Fixes: #10858
PR-URL: #10878
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>

eugeneo commented Jan 20, 2017

Copy link
Copy Markdown
Contributor Author

CI: https://ci.nodejs.org/job/node-test-pull-request/5957/ (all green, despite what GitHub shows)

eugeneo closed this Jan 20, 2017
eugeneo merged commit ba776b3 into nodejs:master Jan 20, 2017
eugeneo deleted the no-assert branch January 20, 2017 17:13
targos pushed a commit that referenced this pull request Jan 28, 2017
inspector: no crash when WS server can't start
8142b09 
This change also changes error message to make it consistent with the
one printed by the debugger.

Fixes: #10858
PR-URL: #10878
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
italoacasas mentioned this pull request Jan 29, 2017
Merged
italoacasas pushed a commit to italoacasas/node that referenced this pull request Jan 30, 2017
inspector: no crash when WS server can't start
9a111e7 
This change also changes error message to make it consistent with the
one printed by the debugger.

Fixes: nodejs#10858
PR-URL: nodejs#10878
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
italoacasas pushed a commit to italoacasas/node that referenced this pull request Jan 30, 2017
inspector: no crash when WS server can't start
6e306fe 
This change also changes error message to make it consistent with the
one printed by the debugger.

Fixes: nodejs#10858
PR-URL: nodejs#10878
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
eugeneo mentioned this pull request Feb 28, 2017
Closed

jasnell commented Mar 8, 2017

Copy link
Copy Markdown
Member

A backport PR is required in order for this to land on v6

This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

bnoordhuis bnoordhuis approved these changes
jasnell jasnell approved these changes
cjihrig cjihrig approved these changes

Assignees

No one assigned

Labels

c++ Issues and PRs that require attention from people who are familiar with C++. inspector Issues and PRs related to the V8 inspector protocol

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

inspector aborts when another process is running the inspector

7 participants

Back | FazBrowse Home | New Git URL