FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

test: add dgram.Socket.prototype.bind's test by hiroppy · Pull Request #10894 · nodejs/node · GitHub

/ node Public

test: add dgram.Socket.prototype.bind's test - #10894

Closed
hiroppy wants to merge 1 commit into
nodejs:masterfrom
hiroppy:feature/add-socket-bind-test
ConversationCommits (1)ChecksFiles changed
Closed

test: add dgram.Socket.prototype.bind's test#10894
hiroppy wants to merge 1 commit into
nodejs:masterfrom
hiroppy:feature/add-socket-bind-test

Conversation

hiroppy commented Jan 19, 2017

Copy link
Copy Markdown
Member

bind: https://github.com/nodejs/node/blob/master/lib/dgram.js#L140

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • commit message follows commit guidelines
Affected core subsystem(s)

test

nodejs-github-bot added test Issues and PRs related to the tests. dont-land-on-v7.x labels Jan 19, 2017
mscdex added the dgram Issues and PRs related to the dgram subsystem / UDP. label Jan 19, 2017
mscdex reviewed Jan 19, 2017
View reviewed changes
Comment thread test/parallel/test-dgram-bind.js Outdated

mscdex Jan 19, 2017

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Perhaps wrap the callback in common.mustCall()?

hiroppy Jan 19, 2017

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Thanks. Added.

lpinca approved these changes Jan 19, 2017
View reviewed changes

lpinca left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

LGTM with @mscdex's comment addressed.

hiroppy force-pushed the feature/add-socket-bind-test branch from faa7fa1 to ac999d3 Compare January 19, 2017 07:37
claudiorodriguez approved these changes Jan 19, 2017
View reviewed changes

claudiorodriguez left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

LGTM

italoacasas commented Jan 19, 2017

Copy link
Copy Markdown

CI: https://ci.nodejs.org/job/node-test-pull-request/5953/console

targos commented Jan 22, 2017

Copy link
Copy Markdown
Member

Landed in ff75e21

targos closed this Jan 22, 2017
targos pushed a commit that referenced this pull request Jan 22, 2017
test: add dgram.Socket.prototype.bind's test
ff75e21 
Test that an error is thrown when bind() is called on an already bound
socket.

PR-URL: #10894
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Claudio Rodriguez <cjrodr@yahoo.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Italo A. Casas <me@italoacasas.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
hiroppy deleted the feature/add-socket-bind-test branch January 23, 2017 05:05
italoacasas mentioned this pull request Jan 25, 2017
Closed
targos pushed a commit that referenced this pull request Jan 28, 2017
test: add dgram.Socket.prototype.bind's test
8e3c142 
Test that an error is thrown when bind() is called on an already bound
socket.

PR-URL: #10894
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Claudio Rodriguez <cjrodr@yahoo.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Italo A. Casas <me@italoacasas.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
italoacasas mentioned this pull request Jan 29, 2017
Merged
italoacasas pushed a commit to italoacasas/node that referenced this pull request Jan 30, 2017
test: add dgram.Socket.prototype.bind's test
90a9917 
Test that an error is thrown when bind() is called on an already bound
socket.

PR-URL: nodejs#10894
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Claudio Rodriguez <cjrodr@yahoo.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Italo A. Casas <me@italoacasas.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
italoacasas pushed a commit to italoacasas/node that referenced this pull request Jan 30, 2017
test: add dgram.Socket.prototype.bind's test
5e364ad 
Test that an error is thrown when bind() is called on an already bound
socket.

PR-URL: nodejs#10894
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Claudio Rodriguez <cjrodr@yahoo.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Italo A. Casas <me@italoacasas.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
jasnell pushed a commit that referenced this pull request Mar 8, 2017
test: add dgram.Socket.prototype.bind's test
535a424 
Test that an error is thrown when bind() is called on an already bound
socket.

PR-URL: #10894
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Claudio Rodriguez <cjrodr@yahoo.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Italo A. Casas <me@italoacasas.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
jasnell pushed a commit that referenced this pull request Mar 8, 2017
test: add dgram.Socket.prototype.bind's test
9232aa3 
Test that an error is thrown when bind() is called on an already bound
socket.

PR-URL: #10894
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Claudio Rodriguez <cjrodr@yahoo.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Italo A. Casas <me@italoacasas.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
MylesBorins pushed a commit that referenced this pull request Mar 9, 2017
test: add dgram.Socket.prototype.bind's test
2a52a68 
Test that an error is thrown when bind() is called on an already bound
socket.

PR-URL: #10894
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Claudio Rodriguez <cjrodr@yahoo.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Italo A. Casas <me@italoacasas.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
MylesBorins mentioned this pull request Mar 9, 2017
Merged
MylesBorins pushed a commit that referenced this pull request Mar 9, 2017
test: add dgram.Socket.prototype.bind's test
4d1f7b1 
Test that an error is thrown when bind() is called on an already bound
socket.

PR-URL: #10894
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Claudio Rodriguez <cjrodr@yahoo.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Italo A. Casas <me@italoacasas.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
MylesBorins mentioned this pull request Mar 9, 2017
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

jasnell jasnell approved these changes
lpinca lpinca approved these changes
cjihrig cjihrig approved these changes
+4 more reviewers
mscdex mscdex left review comments
targos targos approved these changes
claudiorodriguez claudiorodriguez approved these changes
italoacasas italoacasas approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

dgram Issues and PRs related to the dgram subsystem / UDP. test Issues and PRs related to the tests.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

9 participants

Back | FazBrowse Home | New Git URL