FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

test: add dgram.Socket.prototype.sendto's test by hiroppy · Pull Request #10901 · nodejs/node · GitHub

/ node Public

test: add dgram.Socket.prototype.sendto's test - #10901

Closed
hiroppy wants to merge 1 commit into
nodejs:masterfrom
hiroppy:feature/add-test-dgram-sendto
ConversationCommits (1)ChecksFiles changed
Closed

test: add dgram.Socket.prototype.sendto's test#10901
hiroppy wants to merge 1 commit into
nodejs:masterfrom
hiroppy:feature/add-test-dgram-sendto

Conversation

hiroppy commented Jan 19, 2017

Copy link
Copy Markdown
Member

sendto: https://github.com/nodejs/node/blob/master/lib/dgram.js#L234

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • commit message follows commit guidelines
Affected core subsystem(s)

test

nodejs-github-bot added test Issues and PRs related to the tests. lts-watch-v6.x labels Jan 19, 2017
cjihrig requested changes Jan 19, 2017
View reviewed changes
Comment thread test/parallel/test-dgram-sendto.js Outdated

cjihrig Jan 19, 2017

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Can you store this regular expression in a variable for reuse.

hiroppy Jan 19, 2017

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Updated.

hiroppy force-pushed the feature/add-test-dgram-sendto branch from 0dc8717 to df5c0fa Compare January 19, 2017 18:50
mscdex added the dgram Issues and PRs related to the dgram subsystem / UDP. label Jan 19, 2017
cjihrig requested changes Jan 20, 2017
View reviewed changes
Comment thread test/parallel/test-dgram-sendto.js Outdated

cjihrig Jan 20, 2017

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

No need for the RegExp() constructor.

Comment thread test/parallel/test-dgram-sendto.js Outdated

cjihrig Jan 20, 2017

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

If all the sendto() calls are supposed to throw before actually sending, and we're verifying the error messages, I don't think binding, listening, and closing the socket is necessary.

hiroppy force-pushed the feature/add-test-dgram-sendto branch from df5c0fa to 108934d Compare January 20, 2017 01:05
hiroppy force-pushed the feature/add-test-dgram-sendto branch from 108934d to 8ff8f9c Compare January 20, 2017 01:08

Trott commented Jan 20, 2017

Copy link
Copy Markdown
Member

LGTM if CI is green.

I'd leave a nit suggesting being more specific with the identifier name than just errorMessage but I'm having a hard time coming up with something significantly better that isn't probably too long, so ¯\(ツ)/¯.

targos commented Jan 22, 2017

Copy link
Copy Markdown
Member

CI: https://ci.nodejs.org/job/node-test-pull-request/5982/

Tip for the link reference you put in the commit message: You can press Y on your keyboard to get an absolute link to the current revision. That way the line will remain correct even after the file is changed on master.

hiroppy force-pushed the feature/add-test-dgram-sendto branch from 8ff8f9c to 5bacf6e Compare January 23, 2017 02:02

hiroppy commented Jan 23, 2017

Copy link
Copy Markdown
Member Author

@targos Thanks :) I modified this commit message.

targos commented Jan 24, 2017

Copy link
Copy Markdown
Member

Landed in 320108c

targos closed this Jan 24, 2017
targos pushed a commit that referenced this pull request Jan 24, 2017
test: add dgram.Socket.prototype.sendto's test
320108c 
Refs: https://github.com/nodejs/node/blob/09ebdf14005cc948529b3f193ad550d5dfded26a/lib/dgram.js#L234
PR-URL: #10901
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
italoacasas pushed a commit to italoacasas/node that referenced this pull request Jan 25, 2017
test: add dgram.Socket.prototype.sendto's test
51945ae 
Refs: https://github.com/nodejs/node/blob/09ebdf14005cc948529b3f193ad550d5dfded26a/lib/dgram.js#L234
PR-URL: nodejs#10901
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
italoacasas mentioned this pull request Jan 25, 2017
Closed
italoacasas pushed a commit to italoacasas/node that referenced this pull request Jan 27, 2017
test: add dgram.Socket.prototype.sendto's test
21eb4d6 
Refs: https://github.com/nodejs/node/blob/09ebdf14005cc948529b3f193ad550d5dfded26a/lib/dgram.js#L234
PR-URL: nodejs#10901
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
italoacasas mentioned this pull request Jan 29, 2017
Merged
italoacasas pushed a commit to italoacasas/node that referenced this pull request Jan 30, 2017
test: add dgram.Socket.prototype.sendto's test
e161dcf 
Refs: https://github.com/nodejs/node/blob/09ebdf14005cc948529b3f193ad550d5dfded26a/lib/dgram.js#L234
PR-URL: nodejs#10901
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
italoacasas pushed a commit to italoacasas/node that referenced this pull request Jan 30, 2017
test: add dgram.Socket.prototype.sendto's test
fd016e7 
Refs: https://github.com/nodejs/node/blob/09ebdf14005cc948529b3f193ad550d5dfded26a/lib/dgram.js#L234
PR-URL: nodejs#10901
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
hiroppy deleted the feature/add-test-dgram-sendto branch February 7, 2017 00:23
MylesBorins pushed a commit that referenced this pull request Mar 8, 2017
test: add dgram.Socket.prototype.sendto's test
4f9e4b4 
Refs: https://github.com/nodejs/node/blob/09ebdf14005cc948529b3f193ad550d5dfded26a/lib/dgram.js#L234
PR-URL: #10901
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>

MylesBorins commented Mar 8, 2017

Copy link
Copy Markdown
Contributor

failures on v4.x, did not land

=== release test-dgram-sendto ===
Path: parallel/test-dgram-sendto
assert.js:361
    throw actual;
    ^

Error: send takes offset and length as args 2 and 3
    at Socket.sendto (dgram.js:237:11)
    at /Users/mborins/code/node/v4.x/test/parallel/test-dgram-sendto.js:11:10
    at _tryBlock (assert.js:320:5)
    at _throws (assert.js:339:12)
    at Function.assert.throws (assert.js:369:3)
    at Object.<anonymous> (/Users/mborins/code/node/v4.x/test/parallel/test-dgram-sendto.js:10:8)
    at Module._compile (module.js:409:26)
    at Object.Module._extensions..js (module.js:416:10)
    at Module.load (module.js:343:32)
    at Function.Module._load (module.js:300:12)

MylesBorins pushed a commit that referenced this pull request Mar 9, 2017
test: add dgram.Socket.prototype.sendto's test
ed76b4a 
Refs: https://github.com/nodejs/node/blob/09ebdf14005cc948529b3f193ad550d5dfded26a/lib/dgram.js#L234
PR-URL: #10901
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
MylesBorins mentioned this pull request Mar 9, 2017
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

jasnell jasnell approved these changes
cjihrig cjihrig approved these changes
+1 more reviewer
targos targos approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

dgram Issues and PRs related to the dgram subsystem / UDP. test Issues and PRs related to the tests.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

8 participants

Back | FazBrowse Home | New Git URL