test: check error msg in test/parallel/test-fs-make-callback.js - #10914
Closed
legalcodes wants to merge 2 commits into
Closed
test: check error msg in test/parallel/test-fs-make-callback.js#10914legalcodes wants to merge 2 commits into
legalcodes wants to merge 2 commits into
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
cjihrig
approved these changes
Jan 20, 2017
targos
approved these changes
Jan 20, 2017
Copy link
Copy Markdown
Member
Sorry, something went wrong.
italoacasas
approved these changes
Jan 20, 2017
Trott
approved these changes
Jan 20, 2017
Trott
left a comment
Copy link
Copy Markdown
Member
There was a problem hiding this comment.
LGTM
Sorry, something went wrong.
lpinca
reviewed
Jan 21, 2017
Comment thread
test/parallel/test-fs-make-callback.js
| const assert = require('assert'); | ||
| const fs = require('fs'); | ||
| const cbTypeError = /^TypeError: "callback" argument must be a function$/; | ||
|
|
Copy link
Copy Markdown
Member
There was a problem hiding this comment.
Nit: can you please remove this extra new line?
Sorry, something went wrong.
lpinca
approved these changes
Jan 21, 2017
Copy link
Copy Markdown
Member
Sorry, something went wrong.
jasnell
approved these changes
Jan 23, 2017
targos
pushed a commit
that referenced
this pull request
Jan 24, 2017
Add a RegExp to `throws` assertions. PR-URL: #10914 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Italo A. Casas <me@italoacasas.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
italoacasas
pushed a commit
to italoacasas/node
that referenced
this pull request
Jan 25, 2017
Add a RegExp to `throws` assertions. PR-URL: nodejs#10914 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Italo A. Casas <me@italoacasas.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
italoacasas
pushed a commit
to italoacasas/node
that referenced
this pull request
Jan 27, 2017
Add a RegExp to `throws` assertions. PR-URL: nodejs#10914 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Italo A. Casas <me@italoacasas.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
Merged
italoacasas
pushed a commit
to italoacasas/node
that referenced
this pull request
Jan 30, 2017
Add a RegExp to `throws` assertions. PR-URL: nodejs#10914 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Italo A. Casas <me@italoacasas.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
italoacasas
pushed a commit
to italoacasas/node
that referenced
this pull request
Jan 30, 2017
Add a RegExp to `throws` assertions. PR-URL: nodejs#10914 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Italo A. Casas <me@italoacasas.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
Copy link
Copy Markdown
Contributor
|
This does not land cleanly in LTS. Added dont-land label. Please feel free to manually backport |
Sorry, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
10 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Check error message in test/parallel/test-fs-make-callback.js
Checklist
Affected core subsystem(s)