FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

benchmark: add more thorough timers benchmarks by Fishrock123 · Pull Request #10925 · nodejs/node · GitHub

/ node Public

benchmark: add more thorough timers benchmarks - #10925

Merged
Fishrock123 merged 1 commit into
nodejs:masterfrom
Fishrock123:improve-timers-benchmarks
Jan 27, 2017
ConversationCommits (1)ChecksFiles changed
Merged

benchmark: add more thorough timers benchmarks#10925
Fishrock123 merged 1 commit into
nodejs:masterfrom
Fishrock123:improve-timers-benchmarks

Conversation

Fishrock123 commented Jan 20, 2017 •
edited
Loading

Copy link
Copy Markdown
Contributor

Refs: #9493

Adds some new benchmarks to test pooled and unpooled behavior of the insert, cancel, and timeout operations of Node timers.

This is missing an unpooled tests for timeout, since that is far more complex, and I would prefer to do it separately in all likelihood.

cc @misterdjules, @AndreasMadsen, @nodejs/benchmarking

(This patch was made live during https://www.twitch.tv/nodesource/v/117497395 if you'd like to see me working on this in retrospect. :P)

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • commit message follows commit guidelines
Affected core subsystem(s)

benchmark, timer

Fishrock123 added benchmark Issues and PRs related to the benchmark subsystem. timers Issues and PRs related to the timers subsystem / setImmediate, setInterval, setTimeout. labels Jan 20, 2017
nodejs-github-bot added benchmark Issues and PRs related to the benchmark subsystem. lts-watch-v6.x labels Jan 20, 2017
gareth-ellis approved these changes Jan 23, 2017
View reviewed changes

gareth-ellis left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

LGTM

jasnell reviewed Jan 23, 2017
View reviewed changes
Comment thread benchmark/timers/timers-cancel-pooled.js Outdated

jasnell Jan 23, 2017

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

exceedingly minor nit... why N? I tend to dislike caps for variables that aren't const

Fishrock123 force-pushed the improve-timers-benchmarks branch from f2ec826 to d158547 Compare January 24, 2017 20:31

Fishrock123 commented Jan 26, 2017

Copy link
Copy Markdown
Contributor Author

ping again the rest @nodejs/benchmarking, do these look ok?

Fishrock123 force-pushed the improve-timers-benchmarks branch from d158547 to c680d87 Compare January 27, 2017 19:21

Fishrock123 commented Jan 27, 2017

Copy link
Copy Markdown
Contributor Author

Lint CI: https://ci.nodejs.org/job/node-test-linter/6684/

benchmark: add more thorough timers benchmarks
c74e6fe 
Refs: nodejs#9493
PR-URL: nodejs#10925
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Trevor Norris <trev.norris@gmail.com>
Fishrock123 force-pushed the improve-timers-benchmarks branch from c680d87 to c74e6fe Compare January 27, 2017 19:26

Fishrock123 commented Jan 27, 2017

Copy link
Copy Markdown
Contributor Author

Oops, missed a variable rename, new Lint CI: https://ci.nodejs.org/job/node-test-linter/6685/

Fishrock123 merged commit c74e6fe into nodejs:master Jan 27, 2017
Fishrock123 added a commit to Fishrock123/node that referenced this pull request Jan 27, 2017
timers: use Maps for internal duration pooling
bc441b9 
Refs: nodejs#10925
This was referenced Jan 27, 2017
Closed
Closed
evanlucas pushed a commit that referenced this pull request Jan 31, 2017
benchmark: add more thorough timers benchmarks
062c851 
Refs: #9493
PR-URL: #10925
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Trevor Norris <trev.norris@gmail.com>
italoacasas mentioned this pull request Jan 31, 2017
Merged
jasnell pushed a commit that referenced this pull request Mar 8, 2017
benchmark: add more thorough timers benchmarks
dc207cd 
Refs: #9493
PR-URL: #10925
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Trevor Norris <trev.norris@gmail.com>
jasnell pushed a commit that referenced this pull request Mar 8, 2017
benchmark: add more thorough timers benchmarks
c004d43 
Refs: #9493
PR-URL: #10925
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Trevor Norris <trev.norris@gmail.com>
MylesBorins pushed a commit that referenced this pull request Mar 9, 2017
benchmark: add more thorough timers benchmarks
4d6fa8d 
Refs: #9493
PR-URL: #10925
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Trevor Norris <trev.norris@gmail.com>
MylesBorins mentioned this pull request Mar 9, 2017
Merged
MylesBorins pushed a commit that referenced this pull request Mar 9, 2017
benchmark: add more thorough timers benchmarks
14e57c1 
Refs: #9493
PR-URL: #10925
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Trevor Norris <trev.norris@gmail.com>
MylesBorins mentioned this pull request Mar 9, 2017
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

jasnell jasnell approved these changes
+2 more reviewers
trevnorris trevnorris approved these changes
gareth-ellis gareth-ellis approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

benchmark Issues and PRs related to the benchmark subsystem. timers Issues and PRs related to the timers subsystem / setImmediate, setInterval, setTimeout.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

Back | FazBrowse Home | New Git URL