src: remove unnecessary req_wrap_obj - #10942
Closed
danbev wants to merge 1 commit into
Closed
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
The req_wrap_obj is only used in one place which is setting up the arguments for the MakeCallback call. Removing it to simplify the code somewhat.
Copy link
Copy Markdown
Contributor
Author
Sorry, something went wrong.
addaleax
approved these changes
Jan 21, 2017
bnoordhuis
approved these changes
Jan 21, 2017
Copy link
Copy Markdown
Contributor
|
LGTM |
Sorry, something went wrong.
cjihrig
approved these changes
Jan 21, 2017
jasnell
approved these changes
Jan 23, 2017
cjihrig
pushed a commit
to cjihrig/node
that referenced
this pull request
Jan 23, 2017
The req_wrap_obj is only used in one place which is setting up the arguments for the MakeCallback call. Removing it to simplify the code somewhat. PR-URL: nodejs#10942 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Brian White <mscdex@mscdex.net>
italoacasas
pushed a commit
to italoacasas/node
that referenced
this pull request
Jan 25, 2017
The req_wrap_obj is only used in one place which is setting up the arguments for the MakeCallback call. Removing it to simplify the code somewhat. PR-URL: nodejs#10942 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Brian White <mscdex@mscdex.net>
italoacasas
pushed a commit
to italoacasas/node
that referenced
this pull request
Jan 27, 2017
The req_wrap_obj is only used in one place which is setting up the arguments for the MakeCallback call. Removing it to simplify the code somewhat. PR-URL: nodejs#10942 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Brian White <mscdex@mscdex.net>
Merged
italoacasas
pushed a commit
to italoacasas/node
that referenced
this pull request
Jan 30, 2017
The req_wrap_obj is only used in one place which is setting up the arguments for the MakeCallback call. Removing it to simplify the code somewhat. PR-URL: nodejs#10942 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Brian White <mscdex@mscdex.net>
italoacasas
pushed a commit
to italoacasas/node
that referenced
this pull request
Jan 30, 2017
The req_wrap_obj is only used in one place which is setting up the arguments for the MakeCallback call. Removing it to simplify the code somewhat. PR-URL: nodejs#10942 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Brian White <mscdex@mscdex.net>
MylesBorins
pushed a commit
that referenced
this pull request
Mar 8, 2017
The req_wrap_obj is only used in one place which is setting up the arguments for the MakeCallback call. Removing it to simplify the code somewhat. PR-URL: #10942 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Brian White <mscdex@mscdex.net>
MylesBorins
pushed a commit
that referenced
this pull request
Mar 9, 2017
The req_wrap_obj is only used in one place which is setting up the arguments for the MakeCallback call. Removing it to simplify the code somewhat. PR-URL: #10942 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Brian White <mscdex@mscdex.net>
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
8 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The req_wrap_obj is only used in one place which is setting up the
arguments for the MakeCallback call. Removing it to simplify the code
somewhat.
Checklist
Affected core subsystem(s)
src