doc: fix confusing example in dns.md - #11022
Conversation
Sorry, something went wrong.
|
I'd prefer we avoid corporate entities in our example URLs. Not enough to object to this landing, but enough to suggest some alternatives. (I tested these all and they work in the reverse lookup example in the StackOverflow question, at least.) Maybe use each of these in one example?:
|
Sorry, something went wrong.
Does it mean iteration over hostnames array? |
Sorry, something went wrong.
I mean: There are four code examples changed in this PR. In one of those, use iana.org. In the next one, use wikipedia.org. And so on. Just a suggestion. |
Sorry, something went wrong.
|
@Trott Sorry, there are two examples and two comments for them. So it could be only two hostnames. But these two examples illustrate 'functions belonging to two different categories', i.e. they are used in a somehow comparative way. Should we use different hostnames in them? |
Sorry, something went wrong.
|
Oh, my mistake, I see now, yes, just two examples. I don't think it matters much if you use the same hostname in the two examples or different hostnames in each. It was just an idea. Do whichever you think is better! |
Sorry, something went wrong.
Currently, the example throws 'Error: getHostByAddr ENOTFOUND' The previous example is edited for consistency.
|
@Trott I've used the archive.org in the second example as it has most similar input and output forms. Thank you for the suggestions! |
Sorry, something went wrong.
|
Odd that it happens with example.org... |
Sorry, something went wrong.
Sorry, something went wrong.
Trott
left a comment
There was a problem hiding this comment.
LGTM
Sorry, something went wrong.
Currently, the example throws 'Error: getHostByAddr ENOTFOUND' The previous example is edited for consistency. PR-URL: #11022 Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com>
Currently, the example throws 'Error: getHostByAddr ENOTFOUND' The previous example is edited for consistency. PR-URL: nodejs#11022 Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com>
Currently, the example throws 'Error: getHostByAddr ENOTFOUND' The previous example is edited for consistency. PR-URL: #11022 Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com>
Currently, the example throws 'Error: getHostByAddr ENOTFOUND' The previous example is edited for consistency. PR-URL: #11022 Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com>
Currently, the example throws 'Error: getHostByAddr ENOTFOUND' The previous example is edited for consistency. PR-URL: #11022 Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com>
Currently, the example throws 'Error: getHostByAddr ENOTFOUND' The previous example is edited for consistency. PR-URL: #11022 Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com>
Checklist
Affected core subsystem(s)
doc, dns
Currently, the second example throws Error: getHostByAddr ENOTFOUND [IP]. Somebody even posts a question in stackoverflow.com for this very example recently.
Unfortunately, more neutral hostnames (like example.com or github.com) produce the same error. So I've replaced nodejs.org by google.com. If I should use something else, please, tell me.
The previous adjacent example is edited for consistency.