FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

doc: don't imply that we still do io.js releases by bnoordhuis · Pull Request #11054 · nodejs/node · GitHub

/ node Public

doc: don't imply that we still do io.js releases - #11054

Merged
bnoordhuis merged 1 commit into
nodejs:masterfrom
bnoordhuis:update-readme-release-language
Feb 11, 2017
ConversationCommits (1)ChecksFiles changed
Merged

doc: don't imply that we still do io.js releases#11054
bnoordhuis merged 1 commit into
nodejs:masterfrom
bnoordhuis:update-readme-release-language

Conversation

bnoordhuis commented Jan 28, 2017

Copy link
Copy Markdown
Member

Reword the language around releases and signing keys to make it clear
that new releases are all branded "Node.js."

cc @ChALkeR

nodejs-github-bot added doc Issues and PRs related to the documentations. lts-watch-v6.x labels Jan 28, 2017
bnoordhuis mentioned this pull request Jan 28, 2017
Merged
Fishrock123 previously requested changes Jan 28, 2017
View reviewed changes
Comment thread README.md Outdated

Fishrock123 Jan 28, 2017 •
edited
Loading

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Actually, this isn't correct. Most of the current keys were the ones used for signing io.js releases.

ChALkeR Jan 30, 2017

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Perhaps with either one of those or one of the following GPG keys? I'm not sure that's the best way to say it, though.

TimothyGu Jan 30, 2017

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Or how about

-Releases of Node.js and io.js will be signed with one of the following GPG keys:
+Releases of Node.js will be signed with one of the following GPG keys, so have
+previous releases of io.js:

Not the most grammatically correct per se, but it is the most concise I can think of.

bnoordhuis Jan 30, 2017

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

How about I drop the reference to io.js altogether?

Fishrock123 Jan 30, 2017

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Maybe put a line above this one that says: io.js releases may have been signed with any of the keys above or below.

I think hat may be the closest while still easy enough to understand.

Trott Jan 31, 2017

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

We don't support any of the io.js releases anymore anyway. So +1 on just saying Node.js and leaving it at that.

bnoordhuis force-pushed the update-readme-release-language branch from eb519fd to e8e3d7b Compare February 7, 2017 15:26

bnoordhuis commented Feb 7, 2017

Copy link
Copy Markdown
Member Author

Reworded, PTAL.

ChALkeR approved these changes Feb 8, 2017
View reviewed changes

ChALkeR left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

LGTM =).

bnoordhuis commented Feb 8, 2017

Copy link
Copy Markdown
Member Author

@Fishrock123 LGTY?

doc: drop "and io.js" from release section
1062736 
Reword the language around releases and signing keys to make it clear
that new releases are all branded "Node.js."

PR-URL: nodejs#11054
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>
Reviewed-By: Evan Lucas <evanlucas@me.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Сковорода Никита Андреевич <chalkerx@gmail.com>
bnoordhuis force-pushed the update-readme-release-language branch from e8e3d7b to 1062736 Compare February 11, 2017 14:54
bnoordhuis closed this Feb 11, 2017
bnoordhuis deleted the update-readme-release-language branch February 11, 2017 14:54
bnoordhuis merged commit 1062736 into nodejs:master Feb 11, 2017
italoacasas pushed a commit that referenced this pull request Feb 13, 2017
doc: drop "and io.js" from release section
a479746 
Reword the language around releases and signing keys to make it clear
that new releases are all branded "Node.js."

PR-URL: #11054
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>
Reviewed-By: Evan Lucas <evanlucas@me.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Сковорода Никита Андреевич <chalkerx@gmail.com>
italoacasas mentioned this pull request Feb 13, 2017
Merged
italoacasas pushed a commit to italoacasas/node that referenced this pull request Feb 14, 2017
doc: drop "and io.js" from release section
1b08f76 
Reword the language around releases and signing keys to make it clear
that new releases are all branded "Node.js."

PR-URL: nodejs#11054
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>
Reviewed-By: Evan Lucas <evanlucas@me.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Сковорода Никита Андреевич <chalkerx@gmail.com>
krydos pushed a commit to krydos/node that referenced this pull request Feb 25, 2017
doc: drop "and io.js" from release section
4822815 
Reword the language around releases and signing keys to make it clear
that new releases are all branded "Node.js."

PR-URL: nodejs#11054
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>
Reviewed-By: Evan Lucas <evanlucas@me.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Сковорода Никита Андреевич <chalkerx@gmail.com>
jasnell pushed a commit that referenced this pull request Mar 7, 2017
doc: drop "and io.js" from release section
5f041d1 
Reword the language around releases and signing keys to make it clear
that new releases are all branded "Node.js."

PR-URL: #11054
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>
Reviewed-By: Evan Lucas <evanlucas@me.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Сковорода Никита Андреевич <chalkerx@gmail.com>
jasnell pushed a commit that referenced this pull request Mar 7, 2017
doc: drop "and io.js" from release section
a81fbbd 
Reword the language around releases and signing keys to make it clear
that new releases are all branded "Node.js."

PR-URL: #11054
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>
Reviewed-By: Evan Lucas <evanlucas@me.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Сковорода Никита Андреевич <chalkerx@gmail.com>
MylesBorins pushed a commit that referenced this pull request Mar 9, 2017
doc: drop "and io.js" from release section
ade39cd 
Reword the language around releases and signing keys to make it clear
that new releases are all branded "Node.js."

PR-URL: #11054
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>
Reviewed-By: Evan Lucas <evanlucas@me.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Сковорода Никита Андреевич <chalkerx@gmail.com>
MylesBorins mentioned this pull request Mar 9, 2017
Merged
MylesBorins pushed a commit that referenced this pull request Mar 9, 2017
doc: drop "and io.js" from release section
10afa8b 
Reword the language around releases and signing keys to make it clear
that new releases are all branded "Node.js."

PR-URL: #11054
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>
Reviewed-By: Evan Lucas <evanlucas@me.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Сковорода Никита Андреевич <chalkerx@gmail.com>
MylesBorins mentioned this pull request Mar 9, 2017
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

Trott Trott left review comments
ChALkeR ChALkeR approved these changes
jasnell jasnell approved these changes
cjihrig cjihrig approved these changes
+5 more reviewers
Fishrock123 Fishrock123 left review comments
TimothyGu TimothyGu left review comments
danbev danbev approved these changes
evanlucas evanlucas approved these changes
targos targos approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

doc Issues and PRs related to the documentations.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Back | FazBrowse Home | New Git URL