deps: fix npm files from upgrade to 4.1.2 - #11085
Conversation
Sorry, something went wrong.
|
Yeah I'm surprised there wasn't a CI run for that PR... |
Sorry, something went wrong.
jasnell
left a comment
There was a problem hiding this comment.
:-( .... +1 for fast track. The original PR should not have landed in that state
Sorry, something went wrong.
Sorry, something went wrong.
|
+1 for fast-track I think the reason CI wasn't run is that there isn't much that tests deps/npm/ in the native CI (except for test/parallel/test-npm-install.js). However, I think in general that it's always worth running CI, even if we think that it won't catch anything. If I can get #7867 in then we would be able to run the npm tests separately. |
Sorry, something went wrong.
Trott
left a comment
There was a problem hiding this comment.
LGTM. +1 to landing now. (All but 3 CI hosts have finished. Most importantly, Windows is passing.)
Sorry, something went wrong.
PR-URL: #11085 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com>
|
Gonna toss my belated LGTM in there and thanks for fixing these :) |
Sorry, something went wrong.
|
😬 Thanks for merging! |
Sorry, something went wrong.
PR-URL: #11085 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com>
Having multiple files with the same name but different casings causes problems on lots of OS-s. Refs: #12624 Refs: #11085 Refs: #11020 PR-URL: #12643 Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Timothy Gu <timothygu99@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Alexey Orlenko <eaglexrlnk@gmail.com> Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
Having multiple files with the same name but different casings causes problems on lots of OS-s. Refs: #12624 Refs: #11085 Refs: #11020 PR-URL: #12643 Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Timothy Gu <timothygu99@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Alexey Orlenko <eaglexrlnk@gmail.com> Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
Having multiple files with the same name but different casings causes problems on lots of OS-s. Refs: #12624 Refs: #11085 Refs: #11020 PR-URL: #12643 Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Timothy Gu <timothygu99@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Alexey Orlenko <eaglexrlnk@gmail.com> Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
Having multiple files with the same name but different casings causes problems on lots of OS-s. Refs: #12624 Refs: #11085 Refs: #11020 PR-URL: #12643 Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Timothy Gu <timothygu99@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Alexey Orlenko <eaglexrlnk@gmail.com> Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
#11020 landed adding some files that look like merge temporary files, that are not handled well by Git on Windows. This PR just removes those files.
Is there any objection to fasttracking this? Windows CI is failing all runs for master: https://ci.nodejs.org/view/All/job/node-compile-windows/
cc @nodejs/npm @zkat @Fishrock123
Checklist
Affected core subsystem(s)
Deps