FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

https: fix agent servername option by skenqbx · Pull Request #1110 · nodejs/node · GitHub

/ node Public

https: fix agent servername option - #1110

Closed
skenqbx wants to merge 2 commits into
nodejs:v1.xfrom
skenqbx:fix-https-agent-servername-option
ConversationCommits (2)ChecksFiles changed
Closed

https: fix agent servername option#1110
skenqbx wants to merge 2 commits into
nodejs:v1.xfrom
skenqbx:fix-https-agent-servername-option

Conversation

skenqbx commented Mar 9, 2015

Copy link
Copy Markdown
Contributor

See #1106 for original issue.

As requested; the test first.

This PR also need to be ported to node v0.12 & v0.10

Fishrock123 commented Mar 10, 2015

Copy link
Copy Markdown
Contributor

LGTM, is this actually https only though?

cc @indutny

skenqbx commented Mar 10, 2015

Copy link
Copy Markdown
Contributor Author

@Fishrock123 The servername option relates to SNI, which is a https(tls) feature.

indutny commented Mar 10, 2015

Copy link
Copy Markdown
Member

Will look into it later, please don't land yet ;) (later = 10-12 hours)

On Tuesday, March 10, 2015, Malte-Thorben Bruns notifications@github.com
wrote:

@Fishrock123 https://github.com/Fishrock123 The servername option
relates to SNI, which is a https(tls) feature.

—
Reply to this email directly or view it on GitHub
#1110 (comment).

indutny commented Mar 11, 2015

Copy link
Copy Markdown
Member

Took 16 hours, but finally looking into it.

indutny commented Mar 11, 2015

Copy link
Copy Markdown
Member

I'm not sure what kind of semver tag should it have... Seems to be a bugfix, but is a behaviour change too. cc @Fishrock123 @rvagg ?

indutny pushed a commit that referenced this pull request Mar 11, 2015
https: don't overwrite servername option
8453fbc 
PR-URL: #1110
Reviewed-By: Fedor Indutny <fedor@indutny.com>
Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>

indutny commented Mar 11, 2015

Copy link
Copy Markdown
Member

Landed in 8453fbc, thank you!

indutny closed this Mar 11, 2015
skenqbx mentioned this pull request Mar 13, 2015
Closed
rvagg mentioned this pull request Mar 14, 2015
Closed
imyller mentioned this pull request Sep 18, 2016
Closed
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

Back | FazBrowse Home | New Git URL