FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

doc: fix and modernize code examples in domain.md by vsemozhetbyt · Pull Request #11110 · nodejs/node · GitHub

/ node Public

doc: fix and modernize code examples in domain.md - #11110

Closed
vsemozhetbyt wants to merge 4 commits into
nodejs:masterfrom
vsemozhetbyt:domain.md
ConversationCommits (4)ChecksFiles changed
Closed

doc: fix and modernize code examples in domain.md#11110
vsemozhetbyt wants to merge 4 commits into
nodejs:masterfrom
vsemozhetbyt:domain.md

Conversation

vsemozhetbyt commented Feb 1, 2017 •
edited
Loading

Copy link
Copy Markdown
Contributor
Checklist
  • documentation is changed or added
  • commit message follows commit guidelines
Affected core subsystem(s)

doc, domain

  • var -> const
  • concatenations -> templates
  • add missing space
  • fix variable shadowing (fixed basing on the previous example)

FWIW, until the sealing of the domain's vague fate.

nodejs-github-bot added doc Issues and PRs related to the documentations. domain Issues and PRs related to the domain subsystem. labels Feb 1, 2017
evanlucas reviewed Feb 1, 2017
View reviewed changes
Comment thread doc/api/domain.md Outdated

evanlucas Feb 1, 2017

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Won't this change remove the stack trace?

vsemozhetbyt Feb 1, 2017 •
edited
Loading

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Oh. Yes. Sorry.

I shall revert these ones. It seems something like Error ${util.format(err)} will be much worse.

vsemozhetbyt Feb 1, 2017

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

@evanlucas Reverted.

vsemozhetbyt mentioned this pull request Feb 3, 2017
Closed
4 tasks

vsemozhetbyt commented Feb 6, 2017

Copy link
Copy Markdown
Contributor Author

cc @nodejs/documentation

vsemozhetbyt commented Feb 9, 2017

Copy link
Copy Markdown
Contributor Author

@evanlucas Could we proceed?

vsemozhetbyt commented Feb 14, 2017

Copy link
Copy Markdown
Contributor Author

@evanlucas @jasnell Could this be landed?

evanlucas commented Feb 14, 2017

Copy link
Copy Markdown
Contributor

Yep LGTM. Can you land or would you like me to? Thanks!

vsemozhetbyt commented Feb 14, 2017

Copy link
Copy Markdown
Contributor Author

@evanlucas Sorry, I can't) I am not a collaborator)

evanlucas commented Feb 14, 2017

Copy link
Copy Markdown
Contributor

Landed in 5a42cd1. Thanks!

evanlucas closed this Feb 14, 2017
evanlucas pushed a commit that referenced this pull request Feb 14, 2017
doc: update code examples in domain.md
5a42cd1 
* var -> const
* string concatenation -> template strings

PR-URL: #11110
Reviewed-By: Evan Lucas <evanlucas@me.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
vsemozhetbyt deleted the domain.md branch February 14, 2017 22:17
gibfahn mentioned this pull request Feb 15, 2017
Closed
italoacasas pushed a commit to italoacasas/node that referenced this pull request Feb 16, 2017
doc: update code examples in domain.md
fbeeca9 
* var -> const
* string concatenation -> template strings

PR-URL: nodejs#11110
Reviewed-By: Evan Lucas <evanlucas@me.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
italoacasas pushed a commit that referenced this pull request Feb 22, 2017
doc: update code examples in domain.md
6a45265 
* var -> const
* string concatenation -> template strings

PR-URL: #11110
Reviewed-By: Evan Lucas <evanlucas@me.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
italoacasas mentioned this pull request Feb 25, 2017
Merged
jasnell pushed a commit that referenced this pull request Mar 7, 2017
doc: update code examples in domain.md
39a184c 
* var -> const
* string concatenation -> template strings

PR-URL: #11110
Reviewed-By: Evan Lucas <evanlucas@me.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
jasnell pushed a commit that referenced this pull request Mar 7, 2017
doc: update code examples in domain.md
08a2708 
* var -> const
* string concatenation -> template strings

PR-URL: #11110
Reviewed-By: Evan Lucas <evanlucas@me.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
MylesBorins pushed a commit that referenced this pull request Mar 9, 2017
doc: update code examples in domain.md
8468d82 
* var -> const
* string concatenation -> template strings

PR-URL: #11110
Reviewed-By: Evan Lucas <evanlucas@me.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
MylesBorins mentioned this pull request Mar 9, 2017
Merged
MylesBorins pushed a commit that referenced this pull request Mar 9, 2017
doc: update code examples in domain.md
61ac334 
* var -> const
* string concatenation -> template strings

PR-URL: #11110
Reviewed-By: Evan Lucas <evanlucas@me.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
MylesBorins mentioned this pull request Mar 9, 2017
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

jasnell jasnell approved these changes
+1 more reviewer
evanlucas evanlucas approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

doc Issues and PRs related to the documentations. domain Issues and PRs related to the domain subsystem.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

Back | FazBrowse Home | New Git URL