FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

test: simplify WPT.assert_throws() by Trott · Pull Request #11126 · nodejs/node · GitHub

/ node Public

test: simplify WPT.assert_throws() - #11126

Closed
Trott wants to merge 1 commit into
nodejs:masterfrom
Trott:chewbacca
ConversationCommits (1)ChecksFiles changed
Closed

test: simplify WPT.assert_throws()#11126
Trott wants to merge 1 commit into
nodejs:masterfrom
Trott:chewbacca

Conversation

Trott commented Feb 2, 2017

Copy link
Copy Markdown
Member
Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines
Affected core subsystem(s)

test url

Trott added test Issues and PRs related to the tests. whatwg-url Issues and PRs related to the WHATWG URL implementation. labels Feb 2, 2017
nodejs-github-bot added the test Issues and PRs related to the tests. label Feb 2, 2017
Trott requested a review from joyeecheung February 2, 2017 22:05

Trott commented Feb 2, 2017

Copy link
Copy Markdown
Member Author

/cc @joyeecheung in case there is a subtlety I am missing

Trott commented Feb 2, 2017 •
edited
Loading

Copy link
Copy Markdown
Member Author

Hmmm...oh, I think I see, this API is dictated elsewhere so we (probably) don't want to change it even if it might otherwise make sense to change it for our narrow use in our own tests?

Trott commented Feb 2, 2017

Copy link
Copy Markdown
Member Author

(Aside: It would be great if common.WPT could be documented in the test/README.md where the common module API is documented.)

TimothyGu commented Feb 2, 2017

Copy link
Copy Markdown
Member

this API is dictated elsewhere so we (probably) don't want to change it even if it might otherwise make sense to change it for our narrow use in our own tests?

Yeah, making this kind of subtle changes makes importing tests more difficult. Check out @joyeecheung's explanation (#11079 (comment)) for how WPTs are imported.

Trott commented Feb 2, 2017

Copy link
Copy Markdown
Member Author

(Minimal doc stub for common.WPT here: #11127 If someone wants to do something more complete and informative, by all means, close that PR and open a better one.)

Trott commented Feb 2, 2017

Copy link
Copy Markdown
Member Author

OK, makes sense to me. I'll close this.

Trott closed this Feb 2, 2017
Trott deleted the chewbacca branch January 13, 2022 22:42
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

joyeecheung Awaiting requested review from joyeecheung

Assignees

No one assigned

Labels

test Issues and PRs related to the tests. whatwg-url Issues and PRs related to the WHATWG URL implementation.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

Back | FazBrowse Home | New Git URL