test: improve events coverage to check removeListeners functions - #11140
Closed
cauchym wants to merge 1 commit into
Closed
test: improve events coverage to check removeListeners functions#11140cauchym wants to merge 1 commit into
cauchym wants to merge 1 commit into
Conversation
Copy link
Copy Markdown
Sorry, something went wrong.
cjihrig
approved these changes
Feb 3, 2017
jasnell
approved these changes
Feb 3, 2017
italoacasas
approved these changes
Feb 3, 2017
Copy link
Copy Markdown
Sorry, something went wrong.
mhdawson
approved these changes
Feb 3, 2017
mhdawson
left a comment
Copy link
Copy Markdown
Member
There was a problem hiding this comment.
LGTM
Sorry, something went wrong.
jasnell
pushed a commit
that referenced
this pull request
Feb 3, 2017
PR-URL: #11140 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Italo A. Casas <me@italoacasas.com> Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
italoacasas
pushed a commit
to italoacasas/node
that referenced
this pull request
Feb 4, 2017
PR-URL: nodejs#11140 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Italo A. Casas <me@italoacasas.com> Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
italoacasas
pushed a commit
to italoacasas/node
that referenced
this pull request
Feb 14, 2017
PR-URL: nodejs#11140 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Italo A. Casas <me@italoacasas.com> Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
krydos
pushed a commit
to krydos/node
that referenced
this pull request
Feb 25, 2017
PR-URL: nodejs#11140 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Italo A. Casas <me@italoacasas.com> Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
jasnell
pushed a commit
that referenced
this pull request
Mar 7, 2017
PR-URL: #11140 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Italo A. Casas <me@italoacasas.com> Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
jasnell
pushed a commit
that referenced
this pull request
Mar 7, 2017
PR-URL: #11140 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Italo A. Casas <me@italoacasas.com> Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
MylesBorins
pushed a commit
that referenced
this pull request
Mar 9, 2017
PR-URL: #11140 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Italo A. Casas <me@italoacasas.com> Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
Merged
MylesBorins
pushed a commit
that referenced
this pull request
Mar 9, 2017
PR-URL: #11140 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Italo A. Casas <me@italoacasas.com> Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I improved test coverage for events. I found removeListerers , removeAllListerers tests. However remove(All)Listener(s) function does not pass some points. This PR will improve coverage.
I found this commit, but it seems to need to add tests when _events is undefined.
Checklist
Affected core subsystem(s)
N/A