internal/child_process: move anonymous class out of setupChannel - #11147
Closed
JacksonTian wants to merge 1 commit into
Closed
internal/child_process: move anonymous class out of setupChannel#11147JacksonTian wants to merge 1 commit into
JacksonTian wants to merge 1 commit into
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
Move the anonymous class out of setupChannel to clarify code.
jasnell
approved these changes
Feb 3, 2017
cjihrig
approved these changes
Feb 3, 2017
lpinca
approved these changes
Feb 4, 2017
Copy link
Copy Markdown
Contributor
Author
Sorry, something went wrong.
addaleax
approved these changes
Feb 16, 2017
Copy link
Copy Markdown
Member
|
Landed in f9dc722, had to trim the subject line a bit to fit it into 50 characters. |
Sorry, something went wrong.
addaleax
pushed a commit
that referenced
this pull request
Feb 16, 2017
Move the anonymous class out of setupChannel to clarify code. PR-URL: #11147 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net>
italoacasas
pushed a commit
to italoacasas/node
that referenced
this pull request
Feb 20, 2017
Move the anonymous class out of setupChannel to clarify code. PR-URL: nodejs#11147 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net>
italoacasas
pushed a commit
that referenced
this pull request
Feb 22, 2017
Move the anonymous class out of setupChannel to clarify code. PR-URL: #11147 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net>
Merged
Copy link
Copy Markdown
Member
|
Would need a backport PR to land on v4 |
Sorry, something went wrong.
jasnell
pushed a commit
that referenced
this pull request
Mar 7, 2017
Move the anonymous class out of setupChannel to clarify code. PR-URL: #11147 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net>
Copy link
Copy Markdown
Contributor
Author
|
Hi, @jasnell Let me make sure which is target branch, v4.x or v4.x-staging? |
Sorry, something went wrong.
Copy link
Copy Markdown
Member
|
the target branch for LTS backports should always be the staging branch |
Sorry, something went wrong.
MylesBorins
pushed a commit
that referenced
this pull request
Mar 9, 2017
Move the anonymous class out of setupChannel to clarify code. PR-URL: #11147 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net>
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Move the anonymous class out of setupChannel to clarify code.
Checklist
Affected core subsystem(s)
internal/child_process