doc: adding Italo A. Casas PGP Fingerprint - #11202
Conversation
Sorry, something went wrong.
|
Have you uploaded your (EDIT: public) key to https://sks-keyservers.net/? I can't seem to find you. |
Sorry, something went wrong.
|
@bnoordhuis I did it but seems like is not working :(, working on that. Fixed. |
Sorry, something went wrong.
evanlucas
left a comment
There was a problem hiding this comment.
LGTM, but maybe wait to get signoff from a few other members of @nodejs/release since there are some additional steps to be taken (like getting your public key for promoting the binaries)
Sorry, something went wrong.
jasnell
left a comment
There was a problem hiding this comment.
LGTM once all the necessary other steps are complete :-)
Sorry, something went wrong.
There was a problem hiding this comment.
Can you add the key to the list below (line 378) that includes that command to import the key from the keyserver.
Once this is done I give permission to anyone to change my review to approved
Sorry, something went wrong.
|
I've verified that gpg --keyserver pool.sks-keyservers.net --recv-keys 56730D5401028683275BD3C23EFEFE93C4CFFFE works as expected. I have also taken the liberty of signing the key and sending it to the public key server |
Sorry, something went wrong.
|
I add the command as requested. Thanks, everyone. |
Sorry, something went wrong.
PR-URL: #11202 Reviewed-By: Evan Lucas <evanlucas@me.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Myles Borins <myles.borins@gmail.com>
PR-URL: #11202 Reviewed-By: Evan Lucas <evanlucas@me.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Myles Borins <myles.borins@gmail.com>
PR-URL: nodejs#11202 Reviewed-By: Evan Lucas <evanlucas@me.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Myles Borins <myles.borins@gmail.com>
PR-URL: nodejs#11202 Reviewed-By: Evan Lucas <evanlucas@me.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Myles Borins <myles.borins@gmail.com>
PR-URL: #11202 Reviewed-By: Evan Lucas <evanlucas@me.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Myles Borins <myles.borins@gmail.com>
PR-URL: #11202 Reviewed-By: Evan Lucas <evanlucas@me.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Myles Borins <myles.borins@gmail.com>
PR-URL: #11202 Reviewed-By: Evan Lucas <evanlucas@me.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Myles Borins <myles.borins@gmail.com>
PR-URL: #11202 Reviewed-By: Evan Lucas <evanlucas@me.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Myles Borins <myles.borins@gmail.com>
Adding my PGP Fingerprint to the release team.
CTC vote: nodejs/CTC#48
I have been doing the first part of the release for the last 2 or 3 releases in the current branch (7.x), this week release (7.6.0) is going to be a small one and is going to be easier for me to do the complete release. I ask Evan Lucas in IRC and he is going to help me in the process.
Pending Items:
cc: @nodejs/release @evanlucas