test: improve checks in test-path-parse-format - #11223
Merged
cjihrig merged 1 commit intoFeb 9, 2017
Merged
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
joyeecheung
approved these changes
Feb 7, 2017
jasnell
approved these changes
Feb 7, 2017
evanlucas
approved these changes
Feb 7, 2017
jasnell
approved these changes
Feb 7, 2017
Copy link
Copy Markdown
Contributor
Author
Sorry, something went wrong.
- validate full error messages - use assert.throws() instead of try...catch PR-URL: nodejs#11223 Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Evan Lucas <evanlucas@me.com>
italoacasas
pushed a commit
that referenced
this pull request
Feb 13, 2017
- validate full error messages - use assert.throws() instead of try...catch PR-URL: #11223 Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Evan Lucas <evanlucas@me.com>
italoacasas
pushed a commit
to italoacasas/node
that referenced
this pull request
Feb 14, 2017
- validate full error messages - use assert.throws() instead of try...catch PR-URL: nodejs#11223 Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Evan Lucas <evanlucas@me.com>
krydos
pushed a commit
to krydos/node
that referenced
this pull request
Feb 25, 2017
- validate full error messages - use assert.throws() instead of try...catch PR-URL: nodejs#11223 Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Evan Lucas <evanlucas@me.com>
Copy link
Copy Markdown
Member
|
Would require a backport PR to land in v4 |
Sorry, something went wrong.
jasnell
pushed a commit
that referenced
this pull request
Mar 7, 2017
- validate full error messages - use assert.throws() instead of try...catch PR-URL: #11223 Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Evan Lucas <evanlucas@me.com>
MylesBorins
pushed a commit
that referenced
this pull request
Mar 9, 2017
- validate full error messages - use assert.throws() instead of try...catch PR-URL: #11223 Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Evan Lucas <evanlucas@me.com>
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist
Affected core subsystem(s)
test