doc: edit maxBuffer/Unicode paragraph for clarity - #11228
Closed
Trott wants to merge 2 commits into
Closed
Conversation
Copy link
Copy Markdown
Member
Sorry, something went wrong.
Remove unneeded words from child_process doc.
jasnell
approved these changes
Feb 7, 2017
cjihrig
reviewed
Feb 7, 2017
Comment thread
doc/api/child_process.md
Outdated
| ```js | ||
| console.log('中文测试'); | ||
| ``` | ||
| The `maxBuffer` option specifies the largest number of *octets* allowed on |
Copy link
Copy Markdown
Contributor
There was a problem hiding this comment.
Would you mind replacing octets with bytes. I think more people would recognize bytes, and it's used throughout this document.
Sorry, something went wrong.
cjihrig
approved these changes
Feb 7, 2017
Copy link
Copy Markdown
Member
Author
|
Landed in a3bc9a1 |
Sorry, something went wrong.
Trott
added a commit
to Trott/io.js
that referenced
this pull request
Feb 9, 2017
Remove unneeded words from child_process doc. PR-URL: nodejs#11228 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
italoacasas
pushed a commit
that referenced
this pull request
Feb 13, 2017
Remove unneeded words from child_process doc. PR-URL: #11228 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
italoacasas
pushed a commit
to italoacasas/node
that referenced
this pull request
Feb 14, 2017
Remove unneeded words from child_process doc. PR-URL: nodejs#11228 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
krydos
pushed a commit
to krydos/node
that referenced
this pull request
Feb 25, 2017
Remove unneeded words from child_process doc. PR-URL: nodejs#11228 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
jasnell
pushed a commit
that referenced
this pull request
Mar 7, 2017
Remove unneeded words from child_process doc. PR-URL: #11228 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Copy link
Copy Markdown
Member
|
would need a backport PR to land on v4 |
Sorry, something went wrong.
MylesBorins
pushed a commit
that referenced
this pull request
Mar 9, 2017
Remove unneeded words from child_process doc. PR-URL: #11228 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Remove unneeded words from child_process doc.
Checklist
Affected core subsystem(s)
doc child_process