FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

test: increase dgram ref()/unref() coverage by cjihrig · Pull Request #11240 · nodejs/node · GitHub

/ node Public

test: increase dgram ref()/unref() coverage - #11240

Merged
cjihrig merged 1 commit into
nodejs:masterfrom
cjihrig:ref-unref
Feb 10, 2017
ConversationCommits (1)ChecksFiles changed
Merged

test: increase dgram ref()/unref() coverage#11240
cjihrig merged 1 commit into
nodejs:masterfrom
cjihrig:ref-unref

Conversation

cjihrig commented Feb 8, 2017

Copy link
Copy Markdown
Contributor

This commit completes code coverage for dgram's Socket#ref() and Socket#unref() methods.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • commit message follows commit guidelines
Affected core subsystem(s)

test

nodejs-github-bot added the test Issues and PRs related to the tests. label Feb 8, 2017
mscdex added the dgram Issues and PRs related to the dgram subsystem / UDP. label Feb 8, 2017

cjihrig commented Feb 10, 2017

Copy link
Copy Markdown
Contributor Author

cc: @nodejs/testing

santigimeno reviewed Feb 10, 2017
View reviewed changes
Comment thread test/parallel/test-dgram-unref.js Outdated

santigimeno Feb 10, 2017

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Is the call to bind() necessary?

cjihrig Feb 10, 2017

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

The test will run without the bind(), but binding keeps the event loop open and causes the test to timeout if unref'ing doesn't actually work.

santigimeno Feb 10, 2017

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Got it. Thanks!

santigimeno approved these changes Feb 10, 2017
View reviewed changes

santigimeno left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

LGTM with a question?

cjihrig commented Feb 10, 2017

Copy link
Copy Markdown
Contributor Author

CI: https://ci.nodejs.org/job/node-test-pull-request/6337/

test: increase dgram ref()/unref() coverage
b471392 
This commit completes code coverage for dgram's Socket#ref() and
Socket#unref() methods.

PR-URL: nodejs#11240
Reviewed-By: Santiago Gimeno <santiago.gimeno@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
cjihrig merged commit b471392 into nodejs:master Feb 10, 2017
cjihrig deleted the ref-unref branch February 10, 2017 17:55
italoacasas pushed a commit that referenced this pull request Feb 13, 2017
test: increase dgram ref()/unref() coverage
f3d147f 
This commit completes code coverage for dgram's Socket#ref() and
Socket#unref() methods.

PR-URL: #11240
Reviewed-By: Santiago Gimeno <santiago.gimeno@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
italoacasas mentioned this pull request Feb 13, 2017
Merged
italoacasas pushed a commit to italoacasas/node that referenced this pull request Feb 14, 2017
test: increase dgram ref()/unref() coverage
2333cd3 
This commit completes code coverage for dgram's Socket#ref() and
Socket#unref() methods.

PR-URL: nodejs#11240
Reviewed-By: Santiago Gimeno <santiago.gimeno@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
krydos pushed a commit to krydos/node that referenced this pull request Feb 25, 2017
test: increase dgram ref()/unref() coverage
33c9335 
This commit completes code coverage for dgram's Socket#ref() and
Socket#unref() methods.

PR-URL: nodejs#11240
Reviewed-By: Santiago Gimeno <santiago.gimeno@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>

jasnell commented Mar 8, 2017

Copy link
Copy Markdown
Member

Landing on v6. Needs a backport PR if it should land on v4

jasnell pushed a commit that referenced this pull request Mar 8, 2017
test: increase dgram ref()/unref() coverage
23e2a42 
This commit completes code coverage for dgram's Socket#ref() and
Socket#unref() methods.

PR-URL: #11240
Reviewed-By: Santiago Gimeno <santiago.gimeno@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
MylesBorins pushed a commit that referenced this pull request Mar 9, 2017
test: increase dgram ref()/unref() coverage
b29165f 
This commit completes code coverage for dgram's Socket#ref() and
Socket#unref() methods.

PR-URL: #11240
Reviewed-By: Santiago Gimeno <santiago.gimeno@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
MylesBorins mentioned this pull request Mar 9, 2017
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

santigimeno santigimeno approved these changes
jasnell jasnell approved these changes

Assignees

No one assigned

Labels

dgram Issues and PRs related to the dgram subsystem / UDP. test Issues and PRs related to the tests.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

Back | FazBrowse Home | New Git URL