test: qs.escape with multibyte characters under 0x800 - #11251
Closed
watilde wants to merge 1 commit into
Closed
Conversation
Copy link
Copy Markdown
Member
Sorry, something went wrong.
bnoordhuis
approved these changes
Feb 9, 2017
bnoordhuis
left a comment
Copy link
Copy Markdown
Member
There was a problem hiding this comment.
LGTM but can you trim the commit log to <= 50 characters? Thanks.
Sorry, something went wrong.
Add a test case for querystring.parse with multibyte characters under 0x800. PR-URL: nodejs#11251
watilde
force-pushed
the
test-qs-escape
branch
from
1dd1a07 to
8bb75cb
Compare
February 9, 2017 06:13
jasnell
approved these changes
Feb 9, 2017
jasnell
pushed a commit
that referenced
this pull request
Feb 11, 2017
Add a test case for querystring.parse with multibyte characters under 0x800. PR-URL: #11251 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: James M Snell <jasnell@gmail.com>
italoacasas
pushed a commit
that referenced
this pull request
Feb 13, 2017
Add a test case for querystring.parse with multibyte characters under 0x800. PR-URL: #11251 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: James M Snell <jasnell@gmail.com>
italoacasas
pushed a commit
to italoacasas/node
that referenced
this pull request
Feb 14, 2017
Add a test case for querystring.parse with multibyte characters under 0x800. PR-URL: nodejs#11251 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: James M Snell <jasnell@gmail.com>
krydos
pushed a commit
to krydos/node
that referenced
this pull request
Feb 25, 2017
Add a test case for querystring.parse with multibyte characters under 0x800. PR-URL: nodejs#11251 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: James M Snell <jasnell@gmail.com>
Copy link
Copy Markdown
Member
|
would need a backport PR to land on v4 |
Sorry, something went wrong.
jasnell
pushed a commit
that referenced
this pull request
Mar 7, 2017
Add a test case for querystring.parse with multibyte characters under 0x800. PR-URL: #11251 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: James M Snell <jasnell@gmail.com>
MylesBorins
pushed a commit
that referenced
this pull request
Mar 9, 2017
Add a test case for querystring.parse with multibyte characters under 0x800. PR-URL: #11251 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: James M Snell <jasnell@gmail.com>
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Improve test coverage of querystring:
This test case will cover these lines:
node/lib/querystring.js
Lines 169 to 173 in fcedd71
Checklist
Affected core subsystem(s)
test