FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

test: adapt test-debugger-pid to localized Windows by vsemozhetbyt · Pull Request #11270 · nodejs/node · GitHub

/ node Public

test: adapt test-debugger-pid to localized Windows - #11270

Closed
vsemozhetbyt wants to merge 1 commit into
nodejs:masterfrom
vsemozhetbyt:test-debugger-pid
Closed

test: adapt test-debugger-pid to localized Windows#11270
vsemozhetbyt wants to merge 1 commit into
nodejs:masterfrom
vsemozhetbyt:test-debugger-pid

Conversation

Copy link
Copy Markdown
Contributor
Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines
Affected core subsystem(s)

test, debugger

Fixes: #11250

Trott left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

LGTM if CI is green

Trott commented Feb 9, 2017

Copy link
Copy Markdown
Member

Trott added the debugger label Feb 9, 2017
jasnell pushed a commit that referenced this pull request Feb 11, 2017
PR-URL: #11270
Fixes: #11250
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>

jasnell commented Feb 11, 2017

Copy link
Copy Markdown
Member

Landed in a29c85a

jasnell closed this Feb 11, 2017
vsemozhetbyt deleted the test-debugger-pid branch February 11, 2017 17:02
italoacasas pushed a commit that referenced this pull request Feb 13, 2017
PR-URL: #11270
Fixes: #11250
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
italoacasas pushed a commit to italoacasas/node that referenced this pull request Feb 14, 2017
PR-URL: nodejs#11270
Fixes: nodejs#11250
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
krydos pushed a commit to krydos/node that referenced this pull request Feb 25, 2017
PR-URL: nodejs#11270
Fixes: nodejs#11250
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>

jasnell commented Mar 7, 2017

Copy link
Copy Markdown
Member

requires a backport PR in order to land on v4

jasnell pushed a commit that referenced this pull request Mar 7, 2017
PR-URL: #11270
Fixes: #11250
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
MylesBorins pushed a commit that referenced this pull request Mar 9, 2017
PR-URL: #11270
Fixes: #11250
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
MylesBorins mentioned this pull request Mar 9, 2017
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

test Issues and PRs related to the tests.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants


Back | FazBrowse Home | New Git URL