FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

test: consolidating buffer.read() by larissayvette · Pull Request #11297 · nodejs/node · GitHub

/ node Public

test: consolidating buffer.read() - #11297

Closed
larissayvette wants to merge 2 commits into
nodejs:masterfrom
larissayvette:read-buffer
ConversationCommits (2)ChecksFiles changed
Closed

test: consolidating buffer.read()#11297
larissayvette wants to merge 2 commits into
nodejs:masterfrom
larissayvette:read-buffer

Conversation

larissayvette commented Feb 10, 2017

Copy link
Copy Markdown
Contributor
Checklist
Affected core subsystem(s)

test
Merging buffer-read test present in test-buffer-alloc.js to test-buffer-read.js file

nodejs-github-bot added the test Issues and PRs related to the tests. label Feb 10, 2017
Trott approved these changes Feb 10, 2017
View reviewed changes

Trott left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

LGTM if CI is green.

mscdex added the buffer Issues and PRs related to the buffer subsystem. label Feb 10, 2017
thefourtheye reviewed Feb 12, 2017
View reviewed changes
Comment thread test/parallel/test-buffer-read.js

// attempt to overflow buffers, similar to previous bug in array buffers
assert.throws(() => Buffer.allocUnsafe(8).readFloatLE(0xffffffff),
RangeError);

thefourtheye Feb 12, 2017

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Can we check the actual errors itself, so that we can avoid problems like #11162?

Trott Feb 14, 2017

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

I'm in favor of this, but since this PR is a straightforward re-organization of the tests and not actual changes/enhancements, I'd be OK with that happening in a subsequent PR.

Trott commented Feb 14, 2017

Copy link
Copy Markdown
Member

CI: https://ci.nodejs.org/job/node-test-pull-request/6408/

jasnell commented Feb 16, 2017

Copy link
Copy Markdown
Member

one failure in ci is unrelated

jasnell pushed a commit that referenced this pull request Feb 17, 2017
test: consolidate buffer.read() in a file
8a25e31 
PR-URL: #11297
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>

jasnell commented Feb 17, 2017

Copy link
Copy Markdown
Member

landed in 8a25e31

jasnell closed this Feb 17, 2017
larissayvette deleted the read-buffer branch February 17, 2017 09:27
italoacasas pushed a commit to italoacasas/node that referenced this pull request Feb 20, 2017
test: consolidate buffer.read() in a file
3bd6845 
PR-URL: nodejs#11297
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
italoacasas pushed a commit that referenced this pull request Feb 22, 2017
test: consolidate buffer.read() in a file
add7625 
PR-URL: #11297
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
italoacasas mentioned this pull request Feb 25, 2017
Merged

jasnell commented Mar 7, 2017

Copy link
Copy Markdown
Member

would need a backport PR to land on v4

jasnell pushed a commit that referenced this pull request Mar 7, 2017
test: consolidate buffer.read() in a file
fcad958 
PR-URL: #11297
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
MylesBorins pushed a commit that referenced this pull request Mar 9, 2017
test: consolidate buffer.read() in a file
5a92fc2 
PR-URL: #11297
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
MylesBorins mentioned this pull request Mar 9, 2017
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

Trott Trott approved these changes
jasnell jasnell approved these changes
+1 more reviewer
thefourtheye thefourtheye left review comments
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

buffer Issues and PRs related to the buffer subsystem. test Issues and PRs related to the tests.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

Back | FazBrowse Home | New Git URL