update licenses and remove v8_inspector deps license - #11310
Closed
thefourtheye wants to merge 2 commits into
Closed
update licenses and remove v8_inspector deps license#11310thefourtheye wants to merge 2 commits into
thefourtheye wants to merge 2 commits into
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
nodejs#9028 made Node.js use the V8 inspector bundled with the deps/v8 and removed the third party dependency. We can safely omit the non-existent license file.
Generated with tools/license-builder.sh.
Copy link
Copy Markdown
Member
|
Are the changes to LICENSE the result of running license-builder.sh? Aside 1: I was planning on landing #11239 later today. You probably need to rebase after that. Aside 2: is deps/v8_inspector only used for generating v8_inspector_protocol_json.h now? Seems kind of wasteful to keep it around just for that. I'm going to look into that. (EDIT: No, it's used for more than just that.) |
Sorry, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#9028 made Node.js use the V8
inspector bundled with the deps/v8 and removed the third party
dependency. We can safely omit the non-existent license file.
Checklist
Affected core subsystem(s)