FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

test: add cases for unescape & unescapeBuffer by watilde · Pull Request #11326 · nodejs/node · GitHub

/ node Public

test: add cases for unescape & unescapeBuffer - #11326

Closed
watilde wants to merge 1 commit into
nodejs:masterfrom
watilde:test-qs
ConversationCommits (1)ChecksFiles changed
Closed

test: add cases for unescape & unescapeBuffer#11326
watilde wants to merge 1 commit into
nodejs:masterfrom
watilde:test-qs

Conversation

watilde commented Feb 12, 2017 •
edited
Loading

Copy link
Copy Markdown
Member

Increase coverage of querystring:

This test case will cover these lines:

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • commit message follows commit guidelines
Affected core subsystem(s)

test, querystring

nodejs-github-bot added the test Issues and PRs related to the tests. label Feb 12, 2017
mscdex added the querystring Issues and PRs related to the built-in querystring module. label Feb 12, 2017
TimothyGu suggested changes Feb 12, 2017
View reviewed changes
Comment thread test/parallel/test-querystring.js Outdated

TimothyGu Feb 12, 2017

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

I'd prefer having more direct tests against qs.unescapeBuffer() in addition to the indirect ones for qs.unescape(). Here are some nice test cases for unescapeBuffer().

watilde Feb 12, 2017

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Thanks for pointing them! I've picked them and updated the test.

watilde mentioned this pull request Feb 12, 2017
Closed
3 tasks

hiroppy commented Feb 12, 2017

Copy link
Copy Markdown
Member

CI: https://ci.nodejs.org/job/node-test-pull-request/6367/

jasnell commented Feb 16, 2017

Copy link
Copy Markdown
Member

@TimothyGu ... PTAL

TimothyGu commented Feb 17, 2017

Copy link
Copy Markdown
Member

@watilde, sorry for not being clear. What I meant is calling qs.unescapeBuffer() directly, i.e. not though qs.unescape().

watilde commented Feb 17, 2017

Copy link
Copy Markdown
Member Author

@TimothyGu To test this line, I needed calling qs.unescape() instead of qs.unescapeBuffer() to make an error by passing an option { decodeURIComponent: errDecode }.

TimothyGu commented Feb 17, 2017

Copy link
Copy Markdown
Member

@watilde, how about both?

test: add cases for unescape & unescapeBuffer
9457020 
These two functions in the querystring are used as a fallback.
To test them, two test cases were added which make errors that
will be caught.

watilde commented Feb 17, 2017

Copy link
Copy Markdown
Member Author

@TimothyGu Ahh that's nice! I will add it to call the both methods.

watilde commented Feb 17, 2017

Copy link
Copy Markdown
Member Author

Updates:

mhdawson approved these changes Feb 17, 2017
View reviewed changes

mhdawson left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

LGTM

mhdawson commented Feb 17, 2017

Copy link
Copy Markdown
Member

CI run: https://ci.nodejs.org/job/node-test-pull-request/6477/

jasnell pushed a commit that referenced this pull request Feb 19, 2017
test: add cases for unescape & unescapeBuffer
02acea9 
These two functions in the querystring are used as a fallback.
To test them, two test cases were added which make errors that
will be caught.

PR-URL: #11326
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Timothy Gu <timothygu99@gmail.com>
Reviewed-By: Yuta Hiroto <hello@about-hiroppy.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>

hiroppy commented Feb 25, 2017

Copy link
Copy Markdown
Member

landed in 02acea9

hiroppy closed this Feb 25, 2017
watilde deleted the test-qs branch February 25, 2017 16:08
italoacasas pushed a commit to italoacasas/node that referenced this pull request Feb 25, 2017
test: add cases for unescape & unescapeBuffer
ff927b2 
These two functions in the querystring are used as a fallback.
To test them, two test cases were added which make errors that
will be caught.

PR-URL: nodejs#11326
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Timothy Gu <timothygu99@gmail.com>
Reviewed-By: Yuta Hiroto <hello@about-hiroppy.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
italoacasas mentioned this pull request Feb 25, 2017
Merged
jasnell pushed a commit that referenced this pull request Mar 7, 2017
test: add cases for unescape & unescapeBuffer
4e9c36a 
These two functions in the querystring are used as a fallback.
To test them, two test cases were added which make errors that
will be caught.

PR-URL: #11326
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Timothy Gu <timothygu99@gmail.com>
Reviewed-By: Yuta Hiroto <hello@about-hiroppy.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>

jasnell commented Mar 7, 2017

Copy link
Copy Markdown
Member

This will need a backport PR if it needs to land on v4.x-staging

MylesBorins pushed a commit that referenced this pull request Mar 9, 2017
test: add cases for unescape & unescapeBuffer
f8884dd 
These two functions in the querystring are used as a fallback.
To test them, two test cases were added which make errors that
will be caught.

PR-URL: #11326
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Timothy Gu <timothygu99@gmail.com>
Reviewed-By: Yuta Hiroto <hello@about-hiroppy.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
MylesBorins mentioned this pull request Mar 9, 2017
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

jasnell jasnell approved these changes
cjihrig cjihrig approved these changes
+3 more reviewers
TimothyGu TimothyGu approved these changes
hiroppy hiroppy approved these changes
mhdawson mhdawson approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

querystring Issues and PRs related to the built-in querystring module. test Issues and PRs related to the tests.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

8 participants

Back | FazBrowse Home | New Git URL