FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

errors: port internal/buffer errors to internal/errors by bougarfaoui · Pull Request #11341 · nodejs/node · GitHub

/ node Public

errors: port internal/buffer errors to internal/errors - #11341

Closed
bougarfaoui wants to merge 4 commits into
nodejs:masterfrom
bougarfaoui:internal-errors
ConversationCommits (4)ChecksFiles changed
Closed

errors: port internal/buffer errors to internal/errors#11341
bougarfaoui wants to merge 4 commits into
nodejs:masterfrom
bougarfaoui:internal-errors

Conversation

bougarfaoui commented Feb 13, 2017 •
edited
Loading

Copy link
Copy Markdown
  • Assign codes to errors reported by internal/buffer.js

Ref: #11273

cc @jasnell

Semver-major because this updates specific error messages and converts errors over to use the new internal/errors.js mechanism.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines
Affected core subsystem(s)

errors, buffer

nodejs-github-bot added buffer Issues and PRs related to the buffer subsystem. errors Issues and PRs related to JavaScript errors originated in Node.js core. labels Feb 13, 2017
jasnell requested changes Feb 13, 2017
View reviewed changes
Comment thread lib/internal/buffer.js Outdated

const code = icu.icuErrName(result);
const err = new Error(`Unable to transcode Buffer [${code}]`);
const err = new errors.Error('ERR_UNABlE_TRNSC_BUFF', code);

jasnell Feb 13, 2017

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

type in the code...

jasnell Feb 13, 2017

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Also, it would be better to fully spell out transcode and buffer

bougarfaoui commented Feb 13, 2017

Copy link
Copy Markdown
Author

@jasnell what do you mean by 'type in code...'

jasnell mentioned this pull request Feb 14, 2017
Closed
80 tasks
joyeecheung requested changes Feb 14, 2017
View reviewed changes

joyeecheung left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

This should break test-icu-transcode.js, the test needs to be updated.

joyeecheung added the semver-major PRs that contain breaking changes and should be released in the next major version. label Feb 14, 2017

joyeecheung commented Feb 15, 2017

Copy link
Copy Markdown
Member

CI: https://ci.nodejs.org/job/node-test-pull-request/6429/

jasnell added the blocked PRs that are blocked by other issues or PRs. label Apr 5, 2017

fhinkel commented Jun 7, 2017

Copy link
Copy Markdown
Contributor

I'm closing this because it's been inactive for quite a while. Feel free to reopen or ping a collaborator to get it reopened if needed.

fhinkel closed this Jun 7, 2017
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

jasnell jasnell requested changes
joyeecheung joyeecheung requested changes

Assignees

No one assigned

Labels

blocked PRs that are blocked by other issues or PRs. buffer Issues and PRs related to the buffer subsystem. errors Issues and PRs related to JavaScript errors originated in Node.js core. semver-major PRs that contain breaking changes and should be released in the next major version.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

Back | FazBrowse Home | New Git URL