tls: avoid potentially deoptimizing use of arguments - #11357
Closed
jasnell wants to merge 1 commit into
Closed
Conversation
Copy link
Copy Markdown
Member
Sorry, something went wrong.
Replace use of arguments with `...args` ``` tls/tls-connect.js dur=5 concurrency=1 -9.43 % 0.172136744 tls/tls-connect.js dur=5 concurrency=10 29.05 % ** 0.001108115 ```
sam-github
approved these changes
Feb 13, 2017
ChALkeR
approved these changes
Feb 13, 2017
ChALkeR
left a comment
Copy link
Copy Markdown
Member
There was a problem hiding this comment.
...args is fast now, it seems? Yay!
LGTM.
Sorry, something went wrong.
Copy link
Copy Markdown
Contributor
|
@ChALkeR It seems at least partly: https://twitter.com/bmeurer/status/824182909317902336 |
Sorry, something went wrong.
Trott
approved these changes
Feb 14, 2017
Trott
left a comment
Copy link
Copy Markdown
Member
There was a problem hiding this comment.
LGTM if CI is green
Sorry, something went wrong.
lpinca
approved these changes
Feb 14, 2017
cjihrig
approved these changes
Feb 14, 2017
Copy link
Copy Markdown
Member
Author
Sorry, something went wrong.
jasnell
added a commit
that referenced
this pull request
Feb 15, 2017
Replace use of arguments with `...args` ``` tls/tls-connect.js dur=5 concurrency=1 -9.43 % 0.172136744 tls/tls-connect.js dur=5 concurrency=10 29.05 % ** 0.001108115 ``` PR-URL: #11357 Reviewed-By: Sam Roberts <vieuxtech@gmail.com> Reviewed-By: Сковорода Никита Андреевич <chalkerx@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
italoacasas
pushed a commit
to italoacasas/node
that referenced
this pull request
Feb 16, 2017
Replace use of arguments with `...args` ``` tls/tls-connect.js dur=5 concurrency=1 -9.43 % 0.172136744 tls/tls-connect.js dur=5 concurrency=10 29.05 % ** 0.001108115 ``` PR-URL: nodejs#11357 Reviewed-By: Sam Roberts <vieuxtech@gmail.com> Reviewed-By: Сковорода Никита Андреевич <chalkerx@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
italoacasas
pushed a commit
that referenced
this pull request
Feb 22, 2017
Replace use of arguments with `...args` ``` tls/tls-connect.js dur=5 concurrency=1 -9.43 % 0.172136744 tls/tls-connect.js dur=5 concurrency=10 29.05 % ** 0.001108115 ``` PR-URL: #11357 Reviewed-By: Sam Roberts <vieuxtech@gmail.com> Reviewed-By: Сковорода Никита Андреевич <chalkerx@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
8 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replace use of arguments with ...args
/cc @mscdex
Checklist
Affected core subsystem(s)
tls