FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

test, url: turn on WPT tests on empty params pairs by joyeecheung · Pull Request #11369 · nodejs/node · GitHub

/ node Public

test, url: turn on WPT tests on empty params pairs - #11369

Closed
joyeecheung wants to merge 1 commit into
nodejs:masterfrom
joyeecheung:sync-wpt
ConversationCommits (1)ChecksFiles changed
Closed

test, url: turn on WPT tests on empty params pairs#11369
joyeecheung wants to merge 1 commit into
nodejs:masterfrom
joyeecheung:sync-wpt

Conversation

joyeecheung commented Feb 14, 2017

Copy link
Copy Markdown
Member

This is fixed by #11234. This PR turns on the tests accordingly.

Refs: #11234

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • commit message follows commit guidelines
Affected core subsystem(s)

url-whatwg, test

nodejs-github-bot added the test Issues and PRs related to the tests. label Feb 14, 2017
joyeecheung added the whatwg-url Issues and PRs related to the WHATWG URL implementation. label Feb 14, 2017

TimothyGu commented Feb 14, 2017

Copy link
Copy Markdown
Member

CI: https://ci.nodejs.org/job/node-test-pull-request/6399/

TimothyGu approved these changes Feb 14, 2017
View reviewed changes

TimothyGu left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

CI is green (except for ARM but the error looks unrelated). LGTM.

TimothyGu commented Feb 17, 2017

Copy link
Copy Markdown
Member

Landed in 82ddf96.

TimothyGu closed this Feb 17, 2017
TimothyGu pushed a commit that referenced this pull request Feb 17, 2017
test: turn on WPT tests on empty param pairs
82ddf96 
This specific bug was fixed by #11234. This commit turns on the tests
accordingly.

PR-URL: #11369
Ref: #11234
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Timothy Gu <timothygu99@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
jasnell mentioned this pull request Apr 4, 2017
Closed
gibfahn mentioned this pull request Jun 15, 2017
Closed
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

jasnell jasnell approved these changes
cjihrig cjihrig approved these changes
+1 more reviewer
TimothyGu TimothyGu approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

test Issues and PRs related to the tests. whatwg-url Issues and PRs related to the WHATWG URL implementation.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

Back | FazBrowse Home | New Git URL