tools: suggest python2 command in configure - #11375
Closed
silverwind wants to merge 1 commit into
Closed
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
Fishrock123
approved these changes
Feb 14, 2017
jasnell
approved these changes
Feb 14, 2017
cjihrig
approved these changes
Feb 14, 2017
Copy link
Copy Markdown
Contributor
Author
|
Changed it so it suggests a direct call using a found python 2 binary. For example: Please use either Python 2.6 or 2.7: /usr/local/bin/python2 configure If none is found, will print Please use either Python 2.6 or 2.7 |
Sorry, something went wrong.
silverwind
force-pushed
the
configure-python-print
branch
from
610ec6d to
d9ebe5b
Compare
February 14, 2017 16:56
Copy link
Copy Markdown
Contributor
Author
|
Squashed and updated commit title. |
Sorry, something went wrong.
gibfahn
approved these changes
Feb 15, 2017
Try and find a suitable python2 binary and suggest it to the user in case they start the configure script with a incompatible version.
silverwind
force-pushed
the
configure-python-print
branch
from
d9ebe5b to
9d80a26
Compare
February 15, 2017 11:31
2 tasks
silverwind
added a commit
that referenced
this pull request
Feb 16, 2017
Try and find a suitable python2 binary and suggest it to the user in case they start the configure script with a incompatible version. PR-URL: #11375 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
italoacasas
pushed a commit
to italoacasas/node
that referenced
this pull request
Feb 20, 2017
Try and find a suitable python2 binary and suggest it to the user in case they start the configure script with a incompatible version. PR-URL: nodejs#11375 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
italoacasas
pushed a commit
that referenced
this pull request
Feb 22, 2017
Try and find a suitable python2 binary and suggest it to the user in case they start the configure script with a incompatible version. PR-URL: #11375 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
Merged
jasnell
pushed a commit
that referenced
this pull request
Mar 7, 2017
Try and find a suitable python2 binary and suggest it to the user in case they start the configure script with a incompatible version. PR-URL: #11375 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
jasnell
pushed a commit
that referenced
this pull request
Mar 7, 2017
Try and find a suitable python2 binary and suggest it to the user in case they start the configure script with a incompatible version. PR-URL: #11375 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
MylesBorins
pushed a commit
that referenced
this pull request
Mar 9, 2017
Try and find a suitable python2 binary and suggest it to the user in case they start the configure script with a incompatible version. PR-URL: #11375 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
Merged
MylesBorins
pushed a commit
that referenced
this pull request
Mar 9, 2017
Try and find a suitable python2 binary and suggest it to the user in case they start the configure script with a incompatible version. PR-URL: #11375 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist
Affected core subsystem(s)
tools
As suggested by @jbergstroem, this text should be helpful to people on systems where python is python3. Will print:
Ref: #9512 (comment)