FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

timers, errors: migrate to internal/errors.js by shubheksha · Pull Request #11384 · nodejs/node · GitHub

/ node Public

timers, errors: migrate to internal/errors.js - #11384

Closed
shubheksha wants to merge 5 commits into
nodejs:masterfrom
shubheksha:migrate-timers-errors
ConversationCommits (5)ChecksFiles changed
Closed

timers, errors: migrate to internal/errors.js#11384
shubheksha wants to merge 5 commits into
nodejs:masterfrom
shubheksha:migrate-timers-errors

Conversation

shubheksha commented Feb 14, 2017

Copy link
Copy Markdown
Contributor

Fixes #11273

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • documentation is changed or added
  • commit message follows commit guidelines
Affected core subsystem(s)

timers, errors, test

nodejs-github-bot added errors Issues and PRs related to JavaScript errors originated in Node.js core. timers Issues and PRs related to the timers subsystem / setImmediate, setInterval, setTimeout. labels Feb 14, 2017
jasnell added the semver-major PRs that contain breaking changes and should be released in the next major version. label Feb 14, 2017
jasnell requested changes Feb 14, 2017
View reviewed changes

jasnell left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Almost there. Will need to look at one of the errors

Comment thread lib/timers.js Outdated

jasnell Feb 14, 2017

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

hmm.. will have to think about this one because the error message is not going to format that well.

Fishrock123 Feb 14, 2017

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

We could have separate error statements for non-finite and negative numbers

jasnell Feb 14, 2017

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Yeah. It would be a separate error code but that's workable

jasnell Feb 14, 2017

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Yeah. It would be a separate error code but that's workable

joyeecheung Feb 15, 2017

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Note: both #11400 and #11390 touch this kind of error. Definitely +1 on having a error code dedicated for it.

joyeecheung Feb 15, 2017

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Oh, I misunderstood the discussion, it was about throwing different errors for <0 and isFinite, sorry. Anyway I still think there should be something like ERR_NEGATIVE_ARG

fhinkel May 23, 2017

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

@shubheksha do you want to take a stab at addressing @joyeecheung 's comment? Thanks!

jasnell mentioned this pull request Feb 15, 2017
Closed
80 tasks
rauno56 mentioned this pull request Feb 27, 2017
Closed
4 tasks
gibfahn mentioned this pull request Feb 27, 2017
Closed
2 tasks

ChALkeR commented Feb 27, 2017

Copy link
Copy Markdown
Member

Blocked by #11580.

ChALkeR added blocked PRs that are blocked by other issues or PRs. and removed blocked PRs that are blocked by other issues or PRs. labels Feb 27, 2017

ChALkeR commented Mar 6, 2017

Copy link
Copy Markdown
Member

#11580 landed, unblocking.

jasnell added the blocked PRs that are blocked by other issues or PRs. label Apr 5, 2017

fhinkel commented May 23, 2017

Copy link
Copy Markdown
Contributor

@shubheksha Do you want to rebase this so we can pick this up again? Sorry for dragging it out for so long. Hope you're still interested in working on this!

fhinkel added the stalled Issues and PRs that are stalled. label Jun 7, 2017

fhinkel commented Jun 28, 2017

Copy link
Copy Markdown
Contributor

I'm closing this because it's been inactive for quite a while. Feel free to reopen or ping a collaborator to get it reopened if needed.

fhinkel closed this Jun 28, 2017

shubheksha commented Jun 28, 2017

Copy link
Copy Markdown
Contributor Author

Hey @fhinkel, I did rebase this.

targos reopened this Jun 28, 2017
refack mentioned this pull request Jul 15, 2017
Closed
refack self-assigned this Jul 19, 2017
refack removed the blocked PRs that are blocked by other issues or PRs. label Jul 19, 2017

BridgeAR commented Sep 12, 2017

Copy link
Copy Markdown
Member

It seems like these errors were already migrated at some point. I am closing this therefore. @shubheksha I am sorry that your PR could not land and your work is much appreciated nevertheless!

BridgeAR closed this Sep 12, 2017
refack removed their assignment Oct 20, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

jasnell jasnell requested changes
joyeecheung joyeecheung left review comments
+2 more reviewers
fhinkel fhinkel left review comments
Fishrock123 Fishrock123 left review comments
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

errors Issues and PRs related to JavaScript errors originated in Node.js core. semver-major PRs that contain breaking changes and should be released in the next major version. stalled Issues and PRs that are stalled. timers Issues and PRs related to the timers subsystem / setImmediate, setInterval, setTimeout.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

10 participants

Back | FazBrowse Home | New Git URL