(v6.x backport) url: fix surrogate handling in encodeAuth() - #11387
Closed
TimothyGu wants to merge 1 commit into
Closed
(v6.x backport) url: fix surrogate handling in encodeAuth()#11387TimothyGu wants to merge 1 commit into
TimothyGu wants to merge 1 commit into
Conversation
Copy link
Copy Markdown
Member
Sorry, something went wrong.
Merged
MylesBorins
force-pushed
the
v6.x-staging
branch
from
c359018 to
1d631ce
Compare
February 22, 2017 02:08
Copy link
Copy Markdown
Contributor
|
@TimothyGu can you please rebase this and preserve the original commit message from #11161 |
Sorry, something went wrong.
Currently, the legacy URL stringifier miscalculates the offset of an
extra surrogate, causing the high surrogate to be included unescaped:
> url.format({ auth: '\uD83D\uDE00', hostname: 'a' })
'//%F0%9F%98%80�@A'
PR-URL: nodejs#11387
Backport-of: nodejs#11161
Copy link
Copy Markdown
Member
Author
Sorry, something went wrong.
MylesBorins
force-pushed
the
v6.x-staging
branch
from
38935bb to
50523dd
Compare
March 8, 2017 00:16
Copy link
Copy Markdown
Contributor
|
looks like a single failure on arm not ok 179 sequential/test-regress-GH-897 landed in 4fee955 |
Sorry, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently, the legacy URL stringifier miscalculates the offset of an extra surrogate, causing the high surrogate to be included unescaped:
Backport of #11161.
CI: https://ci.nodejs.org/job/node-test-pull-request/6413/
Checklist
Affected core subsystem(s)
url