test: add Unicode characters regression test - #11423
Conversation
Sorry, something went wrong.
This test ensures that UTF-8 characters can be used in core JavaScript modules built into Node's binary. Refs: nodejs#11129
|
hmm... I can't say that I'm too fond of bundling in an internal module whose sole purpose is to support a single test. Adding a simple property to the existing internal/util would work just as well. |
Sorry, something went wrong.
|
Ugh, nevermind... that would cause the entire file to be stored larger than it needs to be. |
Sorry, something went wrong.
| 'use strict'; | ||
|
|
||
| // This module exists entirely for regression testing purposes. | ||
| // See `test/parallel/test-internal-unicode.js`. |
There was a problem hiding this comment.
maybe worth putting unicode in the comment, it looks like some tools care about this.
Sorry, something went wrong.
There was a problem hiding this comment.
That doesn't actually matter much if Unicode characters in comments are encoded properly in Node's binary, if that's what you are talking about, IMO, though they may be useful for debugging, as @Fishrock123 noted. It is quite easy to test Unicode in comments automatically, either exporting a function with a comment inside in this module and checking fn.toString() in the test, or checking the whole value of process.binding('natives')['internal/test/unicode'], but I'd like the status of #11371 and #11417 to become clear before doing this so that this part of the test won't become obsolete as soon as either of these lands (if any). Not to mention that I don't think it is necessary to test Unicode in comments specially at all: how are they different from any other parts of the source code?
Sorry, something went wrong.
Sorry, something went wrong.
jasnell
left a comment
There was a problem hiding this comment.
LGTM if CI is green
Sorry, something went wrong.
This test ensures that UTF-8 characters can be used in core JavaScript modules built into Node's binary. PR-URL: #11423 Ref: #11129 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
This test ensures that UTF-8 characters can be used in core JavaScript modules built into Node's binary. PR-URL: nodejs#11423 Ref: nodejs#11129 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
|
assuming this is related to new URL implementation. added don't land |
Sorry, something went wrong.
|
@MylesBorins no, it's a regression test for issues like this one: #10673. |
Sorry, something went wrong.
This test ensures that UTF-8 characters can be used in core JavaScript modules built into Node's binary.
Refs: #11129
Checklist
Affected core subsystem(s)
test