FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

child_process: remove empty if condition by cjihrig · Pull Request #11427 · nodejs/node · GitHub

/ node Public

child_process: remove empty if condition - #11427

Closed
cjihrig wants to merge 1 commit into
nodejs:masterfrom
cjihrig:logic
Closed

child_process: remove empty if condition#11427
cjihrig wants to merge 1 commit into
nodejs:masterfrom
cjihrig:logic

Conversation

cjihrig commented Feb 16, 2017

Copy link
Copy Markdown
Contributor

This commit replaces an empty if-else-if with a single if condition.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines
Affected core subsystem(s)

child_process

This commit replaces an empty if-else-if with a single if
condition.
nodejs-github-bot added the child_process Issues and PRs related to the child_process subsystem. label Feb 16, 2017

cjihrig commented Feb 17, 2017

Copy link
Copy Markdown
Contributor Author

targos commented Feb 18, 2017

Copy link
Copy Markdown
Member

Landed in a1c652a

targos closed this Feb 18, 2017
targos pushed a commit that referenced this pull request Feb 18, 2017
This commit replaces an empty if-else-if with a single if
condition.

PR-URL: #11427
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Santiago Gimeno <santiago.gimeno@gmail.com>
cjihrig deleted the logic branch February 18, 2017 15:01
addaleax pushed a commit that referenced this pull request Feb 22, 2017
This commit replaces an empty if-else-if with a single if
condition.

PR-URL: #11427
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Santiago Gimeno <santiago.gimeno@gmail.com>
italoacasas mentioned this pull request Feb 25, 2017
jasnell pushed a commit that referenced this pull request Mar 7, 2017
This commit replaces an empty if-else-if with a single if
condition.

PR-URL: #11427
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Santiago Gimeno <santiago.gimeno@gmail.com>
jasnell pushed a commit that referenced this pull request Mar 7, 2017
This commit replaces an empty if-else-if with a single if
condition.

PR-URL: #11427
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Santiago Gimeno <santiago.gimeno@gmail.com>
MylesBorins pushed a commit that referenced this pull request Mar 9, 2017
This commit replaces an empty if-else-if with a single if
condition.

PR-URL: #11427
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Santiago Gimeno <santiago.gimeno@gmail.com>
MylesBorins mentioned this pull request Mar 9, 2017
MylesBorins pushed a commit that referenced this pull request Mar 9, 2017
This commit replaces an empty if-else-if with a single if
condition.

PR-URL: #11427
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Santiago Gimeno <santiago.gimeno@gmail.com>
MylesBorins mentioned this pull request Mar 9, 2017
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

child_process Issues and PRs related to the child_process subsystem.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants


Back | FazBrowse Home | New Git URL