FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

test: improve https coverage to check create connection by chiiia12 · Pull Request #11435 · nodejs/node · GitHub

/ node Public

test: improve https coverage to check create connection - #11435

Closed
chiiia12 wants to merge 1 commit into
nodejs:masterfrom
chiiia12:improve_test_https2
ConversationCommits (1)ChecksFiles changed
Closed

test: improve https coverage to check create connection#11435
chiiia12 wants to merge 1 commit into
nodejs:masterfrom
chiiia12:improve_test_https2

Conversation

chiiia12 commented Feb 17, 2017 •
edited
Loading

Copy link
Copy Markdown

This PR improves https coverage (maybe cover statement 100%).

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • commit message follows commit guidelines
Affected core subsystem(s)

nodejs-github-bot added the test Issues and PRs related to the tests. label Feb 17, 2017
mscdex added the https Issues or PRs related to the https subsystem. label Feb 17, 2017
jasnell requested changes Feb 17, 2017
View reviewed changes

jasnell left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Almost there!

Comment thread test/parallel/test-https-agent-create-connection.js Outdated

jasnell Feb 17, 2017

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

common.mustCall() would be good here too

Comment thread test/parallel/test-https-agent-create-connection.js Outdated

jasnell Feb 17, 2017

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

common.mustCall() here as well

Comment thread test/parallel/test-https-agent-create-connection.js Outdated

jasnell Feb 17, 2017

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

... and here :-)

chiiia12 force-pushed the improve_test_https2 branch from 58cd166 to 2e57fea Compare February 21, 2017 00:47

chiiia12 commented Feb 21, 2017

Copy link
Copy Markdown
Author

@jasnell thanks for reviewing! I fix it.

yosuke-furukawa commented Feb 24, 2017

Copy link
Copy Markdown
Member

LGTM.

hiroppy commented Feb 24, 2017

Copy link
Copy Markdown
Member

CI: https://ci.nodejs.org/job/node-test-pull-request/6575/

hiroppy pushed a commit that referenced this pull request Mar 2, 2017
test: improve https coverage to check create connection
104c9ac 
PR-URL: #11435
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Yuta Hiroto <hello@about-hiroppy.com>

hiroppy commented Mar 2, 2017

Copy link
Copy Markdown
Member

landed in 104c9ac, thanks!

hiroppy closed this Mar 2, 2017

bnoordhuis commented Mar 2, 2017

Copy link
Copy Markdown
Member

See #11644, the test appears to be rather flaky.

addaleax pushed a commit that referenced this pull request Mar 5, 2017
test: improve https coverage to check create connection
cdee945 
PR-URL: #11435
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Yuta Hiroto <hello@about-hiroppy.com>
evanlucas mentioned this pull request Mar 8, 2017
Merged
MylesBorins pushed a commit that referenced this pull request Apr 17, 2017
test: improve https coverage to check create connection
c4a14a2 
PR-URL: #11435
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Yuta Hiroto <hello@about-hiroppy.com>

MylesBorins commented Apr 17, 2017

Copy link
Copy Markdown
Contributor

I've backported including the change that closed #11644

LMK if this should be reverted

MylesBorins pushed a commit that referenced this pull request Apr 19, 2017
test: improve https coverage to check create connection
678e225 
PR-URL: #11435
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Yuta Hiroto <hello@about-hiroppy.com>
MylesBorins mentioned this pull request Apr 19, 2017
Merged
andrew749 pushed a commit to michielbaird/node that referenced this pull request Jul 19, 2017
test: improve https coverage to check create connection
b4b2dbd 
PR-URL: nodejs/node#11435
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Yuta Hiroto <hello@about-hiroppy.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

jasnell jasnell approved these changes
+1 more reviewer
hiroppy hiroppy approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

https Issues or PRs related to the https subsystem. test Issues and PRs related to the tests.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

8 participants

Back | FazBrowse Home | New Git URL