FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

doc: restrict the ES.Next features usage in tests by DavidCai1111 · Pull Request #11452 · nodejs/node · GitHub

/ node Public

doc: restrict the ES.Next features usage in tests - #11452

Closed
DavidCai1111 wants to merge 1 commit into
nodejs:masterfrom
DavidCai1111:doc/test
ConversationCommits (1)ChecksFiles changed
Closed

doc: restrict the ES.Next features usage in tests#11452
DavidCai1111 wants to merge 1 commit into
nodejs:masterfrom
DavidCai1111:doc/test

Conversation

DavidCai1111 commented Feb 18, 2017 •
edited
Loading

Copy link
Copy Markdown
Member

Update the writing-tests guide to restrict the ES.Next features usage in tests for the ease of backporting (only encourage to use those features that can be used directly without a flag in all maintained branches) .

Refs: #11290

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • documentation is changed or added
  • commit message follows commit guidelines
Affected core subsystem(s)

doc

nodejs-github-bot added the doc Issues and PRs related to the documentations. label Feb 18, 2017

DavidCai1111 commented Feb 18, 2017

Copy link
Copy Markdown
Member Author

@mscdex @joyeecheung

i5ting commented Feb 18, 2017

Copy link
Copy Markdown

nice job

joyeecheung reviewed Feb 18, 2017
View reviewed changes
Comment thread doc/guides/writing-tests.md Outdated

joyeecheung Feb 18, 2017

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

May be s/v4.x/all maintained branches for timelessness. (we can add a link to https://github.com/nodejs/lts to explain what are those maintained branches)

joyeecheung Feb 18, 2017

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Also we can add a link to the upcoming backporting guide to the backporting part, doesn't need to happen in this PR though. Pending PR: #11099

DavidCai1111 commented Feb 18, 2017

Copy link
Copy Markdown
Member Author

@joyeecheung Updated, PTAL.

joyeecheung reviewed Feb 18, 2017
View reviewed changes
Comment thread doc/guides/writing-tests.md Outdated

joyeecheung Feb 18, 2017

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

The lts project link should have a text. Maybe [the LTS page](https://github.com/nodejs/lts).

Also nit: 80-character wrap.

joyeecheung Feb 18, 2017

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Actuallyall maintained branches is probably clear enough(no need for the lts/v4.x part). The lts link can be attached to this phrase and the node.green tip can be placed in the parens.

joyeecheung Feb 18, 2017 •
edited
Loading

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Oh uh..by s/v4.x/all maintained branches/ I meant "replace v4.x with all maintained branches"(sed syntax). Sorry for not being clear.

DavidCai1111 Feb 19, 2017 •
edited
Loading

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Thanks for the correction, so "for the ease of backporting, it is encouraged to use those ES.Next features that can be used directly without a flag in [all maintained branches](https://github.com/nodejs/lts), you can check [node.green](http://node.green) for all available features in each release." will be better?

joyeecheung Feb 19, 2017

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Yep :)

DavidCai1111 Feb 19, 2017

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

OK, updated 👍

joyeecheung commented Feb 18, 2017

Copy link
Copy Markdown
Member

@Trott might want to take a look at this?

Trott commented Feb 19, 2017

Copy link
Copy Markdown
Member

@nodejs/testing

Seems A-OK to me.

joyeecheung commented Feb 21, 2017

Copy link
Copy Markdown
Member

Landed in 88035bc, thanks!

joyeecheung pushed a commit that referenced this pull request Feb 21, 2017
doc: restrict the ES.Next features usage in tests
88035bc 
PR-URL: #11452
Refs: #11290
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
addaleax pushed a commit that referenced this pull request Feb 22, 2017
doc: restrict the ES.Next features usage in tests
c5ff76d 
PR-URL: #11452
Refs: #11290
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
italoacasas mentioned this pull request Feb 25, 2017
Merged

jasnell commented Mar 7, 2017

Copy link
Copy Markdown
Member

this would need a backport pr to land in v6 or v4

DavidCai1111 pushed a commit to DavidCai1111/node that referenced this pull request Mar 7, 2017
doc: restrict the ES.Next features usage in tests
9cce019 
PR-URL: nodejs#11452
Refs: nodejs#11290
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
DavidCai1111 mentioned this pull request Mar 7, 2017
Closed
3 tasks

DavidCai1111 commented Mar 7, 2017

Copy link
Copy Markdown
Member Author

@jasnell Backport PR: #11725

MylesBorins commented Mar 8, 2017

Copy link
Copy Markdown
Contributor

@DavidCai1993 I'm noticing a backport to v4.x with a conflict, but no backport to v6.x. Would you be able to do v6 too?

DavidCai1111 commented Mar 8, 2017

Copy link
Copy Markdown
Member Author

@MylesBorins Sure 😄

DavidCai1111 mentioned this pull request Mar 8, 2017
Closed
3 tasks

DavidCai1111 commented Mar 8, 2017

Copy link
Copy Markdown
Member Author

@MylesBorins PR for v6.x: #11743

MylesBorins pushed a commit that referenced this pull request Mar 9, 2017
doc: restrict the ES.Next features usage in tests
c2e818d 
PR-URL: #11452
Refs: #11290
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
MylesBorins pushed a commit that referenced this pull request Mar 9, 2017
doc: restrict the ES.Next features usage in tests
227cc1e 
PR-URL: #11452
Refs: #11290
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
MylesBorins mentioned this pull request Mar 9, 2017
Merged
abhishekumar-tyagi pushed a commit to abhishekumar-tyagi/node that referenced this pull request May 5, 2024
doc: restrict the ES.Next features usage in tests
67f563b 
PR-URL: nodejs/node#11452
Refs: nodejs/node#11290
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

jasnell jasnell approved these changes
lpinca lpinca approved these changes
joyeecheung joyeecheung approved these changes

Assignees

No one assigned

Labels

doc Issues and PRs related to the documentations.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

9 participants

Back | FazBrowse Home | New Git URL