(v7.x backport) URL-related changes - #11457
Closed
TimothyGu wants to merge 8 commits into
Closed
Conversation
Copy link
Copy Markdown
Member
Sorry, something went wrong.
* attributon of WPT in url-setter-tests * add WPT test utilities * synchronize WPT URLSearchParams tests * synchronize WPT url tests * split whatwg-url-inspect test * port historical url tests from WPT * protocol setter and special URLs Refs: web-platform-tests/wpt#4413 Refs: whatwg/url#104 Backport-of: nodejs#11079
Backport-of: nodejs#11098 Fixes: nodejs#10760 Ref: whatwg/url#26 Ref: whatwg/url#199 Ref: web-platform-tests/wpt#4531
Also factor out common parts in querystring and url. Backport-of: nodejs#11161
Backport-of: nodejs#11264
Also remove executable bit from doc/api/url.md's mode. Backport-of: nodejs#11330 Fixes: 84e2ff3 "doc: add basic documentation for WHATWG URL API"
Copy link
Copy Markdown
Member
Author
Sorry, something went wrong.
Copy link
Copy Markdown
Member
|
I'm surprised so many backports are necessary for this feature. Isn't there a previous missing commit that would fix the merge conflicts? |
Sorry, something went wrong.
Copy link
Copy Markdown
|
Yeap, the problem is that #11060 is landed in master but currently is being discussed in the spec repo whatwg/url#204. |
Sorry, something went wrong.
Copy link
Copy Markdown
|
@TimothyGu thanks for the backport I will review it over the weekend. |
Sorry, something went wrong.
jasnell
approved these changes
Feb 19, 2017
italoacasas
approved these changes
Feb 20, 2017
Copy link
Copy Markdown
|
Landed in staging. Thanks for taking the time @TimothyGu |
Sorry, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backports of:
Checklist
Affected core subsystem(s)
url