lib: rename kMaxCallbacksUntilQueueIsShortened - #11473
Closed
JungMinu wants to merge 1 commit into
Closed
Conversation
Copy link
Copy Markdown
Member
Sorry, something went wrong.
2 tasks
danbev
approved these changes
Feb 21, 2017
jasnell
approved these changes
Feb 21, 2017
cjihrig
approved these changes
Feb 21, 2017
Copy link
Copy Markdown
Member
|
Hm. If I understood @trevnorris’s comment in #11199 correctly, kMaxCallbacksUntilQueueIsShortened is a more accurate name, so why not keep it? |
Sorry, something went wrong.
Copy link
Copy Markdown
Contributor
|
Apparently that name was suggested in jest of being overly accurate. |
Sorry, something went wrong.
Copy link
Copy Markdown
Member
|
soo.... I assume this one is good to land? Is this the color we wanna paint the shed? |
Sorry, something went wrong.
Copy link
Copy Markdown
Member
|
Tbh, I still don’t understand exactly what this does and neither name really clears it up. So I won’t stand in the way of anything. 😄 |
Sorry, something went wrong.
jasnell
pushed a commit
that referenced
this pull request
Feb 24, 2017
PR-URL: #11473 Ref: #11199 (comment) Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
addaleax
pushed a commit
that referenced
this pull request
Feb 24, 2017
PR-URL: #11473 Ref: #11199 (comment) Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Merged
jasnell
pushed a commit
that referenced
this pull request
Mar 7, 2017
PR-URL: #11473 Ref: #11199 (comment) Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
MylesBorins
pushed a commit
that referenced
this pull request
Mar 9, 2017
PR-URL: #11473 Ref: #11199 (comment) Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refs: #11199 (comment)
Checklist
Affected core subsystem(s)
lib