src: update http-parser link - #11477
Closed
danbev wants to merge 1 commit into
Closed
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
I noticed that the link to http-parser is pointing to the joyent organization. There is a redirect to the nodejs organization but perhaps this should be updated anyway.
Copy link
Copy Markdown
Contributor
|
The subsystem in the first line of the commit message should be 'deps' instead of 'src'. |
Sorry, something went wrong.
Copy link
Copy Markdown
Contributor
Author
I was thinking that because the file itself where the update is being made is in src directory, the subsystem should also be src. I'm happy to update this just wanted to know for future reference and to avoid make the same mistake again. |
Sorry, something went wrong.
jasnell
approved these changes
Feb 21, 2017
Copy link
Copy Markdown
Contributor
|
@danbev My mistake, I misread the file path. |
Sorry, something went wrong.
cjihrig
approved these changes
Feb 21, 2017
Copy link
Copy Markdown
Member
|
This likely doesn't need to wait the full 48 hours to land |
Sorry, something went wrong.
danbev
added a commit
to danbev/node
that referenced
this pull request
Feb 23, 2017
I noticed that the link to http-parser is pointing to the joyent organization. There is a redirect to the nodejs organization but perhaps this should be updated anyway. PR-URL: nodejs#11477 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
addaleax
pushed a commit
that referenced
this pull request
Feb 24, 2017
I noticed that the link to http-parser is pointing to the joyent organization. There is a redirect to the nodejs organization but perhaps this should be updated anyway. PR-URL: #11477 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Merged
jasnell
pushed a commit
that referenced
this pull request
Mar 7, 2017
I noticed that the link to http-parser is pointing to the joyent organization. There is a redirect to the nodejs organization but perhaps this should be updated anyway. PR-URL: #11477 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
jasnell
pushed a commit
that referenced
this pull request
Mar 7, 2017
I noticed that the link to http-parser is pointing to the joyent organization. There is a redirect to the nodejs organization but perhaps this should be updated anyway. PR-URL: #11477 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
MylesBorins
pushed a commit
that referenced
this pull request
Mar 9, 2017
I noticed that the link to http-parser is pointing to the joyent organization. There is a redirect to the nodejs organization but perhaps this should be updated anyway. PR-URL: #11477 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Merged
MylesBorins
pushed a commit
that referenced
this pull request
Mar 9, 2017
I noticed that the link to http-parser is pointing to the joyent organization. There is a redirect to the nodejs organization but perhaps this should be updated anyway. PR-URL: #11477 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I noticed that the link to http-parser is pointing to the joyent
organization. There is a redirect to the nodejs organization but
perhaps this should be updated anyway.
Checklist
Affected core subsystem(s)
src